(QENG-819) stderr collected for each testcase is incorrect...

...(as seen in beaker xml output)

- keep track of the last result generated through the ssh connection
- add the last stderr to the junit xml output
- clear the collected last result before each test case
(QENG-807) add --collect-perf-data option, rspec tests, and yard docs
Remove dead line of code
(QENG-969) Add modify_tk_config DSL method.

Comes with some "private" helper methods for reading tk config strings and
merging or replacing the SUT config file using Beaker::Options::OptionsHash

Signed-off-by: Wayne <wayne@puppetlabs.com>
(QENG-969) Update `with_puppet_running_on` spec test.

Test that `with_puppet_running_on` actually uses `modify_tk_conf` when the
circumstances are right.

Signed-off-by: Wayne <wayne@puppetlabs.com>
(QENG-969) Addresss PR feedback.

Signed-off-by: Wayne <wayne@puppetlabs.com>
Merge pull request #355 from doug-rosser/atop_integration

(QENG-807) add --collect-perf-data option, rspec tests, and yard docs
Merge pull request #378 from waynr/feature/qeng-969-add-modify-tk-config-dsl-method

Feature/qeng 969 add modify tk config dsl method
(QENG-997) Add PE installer answer for jvm puppet.

Signed-off-by: Wayne <wayne@puppetlabs.com>
(QENG-989,990) Clean up open source install rough edges

This ensures that puppet and friends are available after gem installs on
Solaris and Debian. It also makes sure that the config directory and
hiera.yaml file are aways present. The former change fixes QENG-989 while
the latter fixes QENG-990).

[edit: to address pull request comments]
Merge pull request #374 from justinstoller/bug/master/QENG-989_gem_install_on_solaris

(QENG-989,990) Clean up open source install rough edges
Merge pull request #375 from waynr/feature/qeng-997-add-pe-installer-answer-for-jvm-puppet

(QENG-997) Add PE installer answer for jvm puppet.
Merge pull request #370 from anodelman/junit

(QENG-819) stderr collected for each testcase is incorrect...
(QENG-969) Fix bug introduced with last patch.

Last patch addressed some PR comments regarding coding style and led to bug
which is now fixed.

Signed-off-by: Wayne <wayne@puppetlabs.com>
Revert "Revert "(QENG-431) expanded and improved role support in beaker""
(QENG-431) (cleanup) expanded and improved role support in beaker

- cleanup in response to review comments
(QENG-431) (cleanup + split out filtering) expanded and improved role support in beaker

- split out filtering from applying the block to hosts
- block_on now determines if we have a filter or not
- run_block_on accepts both a set of hosts and an optional filter
Merge pull request #381 from waynr/feature/qeng-969-add-modify-tk-config-dsl-method

(QENG-969) Fix bug introduced with last patch.
Merge pull request #362 from anodelman/revert-343-revert-237-role-repair

(QENG-431) expanded and improved role support in beaker
(QENG-1000) Ensure that add-el-extras works on all rhel platforms

The --add-el-extras options was only working for platform strings of the form
el-(5,6), which meant that you couldn't have beaker add the el repo on a
'centos' platform for instance.

Change makes more use of the Beaker::Platform attributes and checks
other rhel variants (centos, scientific, and the 'redhat' variant is
another platform label used for rhel I believe).