Thanks Jeff, that was a mistake.
-- 
C. R. Oldham, Platform Engineer, SaltStack
cr@saltstack.com


From: Jeff Schroeder notifications@github.com
Reply: saltstack/salt reply@reply.github.com
Date: May 29, 2014 at 9:43:18 PM
To: saltstack/salt salt@noreply.github.com
Cc: C. R. Oldham cr@saltstack.com
Subject:  Re: [salt] External nodes removal (#13123)  

In salt/state.py:

> @@ -2053,13 +2053,13 @@ def top_matches(self, top):
>                      for item in data:
>                          if isinstance(item, string_types):
>                              matches[saltenv].append(item)
> -        ext_matches = self.client.ext_nodes()
> -        for saltenv in ext_matches:
> -            if saltenv in matches:
> -                matches[saltenv] = list(
> -                    set(ext_matches[saltenv]).union(matches[saltenv]))
> -            else:
> -                matches[saltenv] = ext_matches[saltenv]
> +        # ext_matches = self.client.ext_nodes()
> +        # for saltenv in ext_matches:
> +        #     if saltenv in matches:
> +        #         matches[saltenv] = list(
> +        #             set(ext_matches[saltenv]).union(matches[saltenv]))
> +        #     else:
> +        #         matches[saltenv] = ext_matches[saltenv]
You should probably remove this code. Committing commented code doesn't seem like a great idea.

—
Reply to this email directly or view it on GitHub.