I think it's okay. It was intended to be a copy of this:
https://github.com/rails/rails/blob/master/activerecord/lib/active_record/associations/has_many_association.rb