Reject inline comments on files that do not exist in the patch set

Bug: issue 2583
Change-Id: Icaf213f890c10f7f4207e1c3e48c1c8d841bd6d1
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Buck: Simplify acceptance_tests rule invocation

acceptance_tests() rule includes '//gerrit-acceptance-tests:lib'
dependency per default, so there no need to pass it in invocation
of this rules.

Change-Id: Iaf2dad483096cd30cb48dca47fe70c2d2331819e
Buck: Add support for groups of acceptance tests

The number of acceptance tests and the time consuming to run it growing.
To optimize this, this change uses Buck's feature to label a group of
tests.  Currently the following groups are supported:

* api
* git
* pgm
* rest
* server
* ssh

To run only some of groups, the following command can be executed:

  buck test --all --include api rest

To exclude specific groups, the following command can be executed:

  buck test --all --exclude git ssh

Change-Id: Ic339f76654ff60dfc0976a14a12bcea7313c7eef
Discontinue comment visibility strategy for new change screen

As explained in this change [1] comment visibility strategy is replaced
by autoOpen(lastReply) strategy and is going to be removed (also from the
database), when old change screen is removed. Mark label for this setting
on my preference screen as "Old Change Screen" only.

[1] https://gerrit-review.googlesource.com/55536

Bug: Issue 2456
Change-Id: I1b36e9d53a8f35ff0f8f1fb793d3082fb5669452
Use StringListPanel to render ARRAY project plugin config params

So far ARRAY project plugin configuration parameters were rendered as
text area where each line represented one value. Now with the table
from StringListPanel the UI looks nicer and is more comfortable to
use.

Change-Id: Ibcb6dff48eb2ae62990729c6ef655dc1b8823afb
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Describe labels and submit rules in project owner guide

Change-Id: I3f52692757811858c03b85820f8a718e0815ffce
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Add section about email notifications to project owner guide

Change-Id: I8e6483e89ebe09c994d1b194118f4b412fcbe7c1
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Add a section about project dashboards to project owner guide

Change-Id: I33b7f5e4c585387cd81439cf7141ef7c5b18fd41
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Merge "Discontinue comment visibility strategy for new change screen" into stable-2.9
Add missing article "the" in access-control.txt

This patch adds a missing article "the" in a documentation
sentence in access-control.txt.

Change-Id: I12a1bd73f121cb0441554ec3afd6a0a700d35e32
Bump SSHD version to 0.10.1 and enable nio2 backend

46f8488a78742799a4f5f781279c8955460e7964 removed nio2 backend because of
a bug [1].  Given that the bug is fixed and released, enable it again.

Another problem was also fixed and released [2].

Upgrade to the official version 0.10.1 makes Gerrit's own custom patch of
SSHD and hosting it on Google bucket unnecessary.

[1] https://issues.apache.org/jira/browse/SSHD-252
[2] https://issues.apache.org/jira/browse/SSHD-255

Bug: Issue 2406
Change-Id: I6668f6194427f153e1982e14b3936d2f3132fa7d
Update sshd to 0.11.0

Fixes a few issues including a null pointer exception [1] that causes
ssh commands to hang.

It also adds server driven rekeying after 1G bytes of data transferred,
which is a useful security feature.

[1] https://issues.apache.org/jira/browse/SSHD-307

Change-Id: I441995eaf76e4fe53f7991f5aef00e062900791b
Fix: wrongly throw 'commit already exists' exception

The reason is the ReplaceRequest.validate() should compare
to 'newCommit' of ReplaceRequest instance, else when
ReceiveCommits.autoCloseChanges() working on the second one
of a series of commits, the 'commit already exists(in the project)'
will be thrown wrongly.

Fixed.

Bug: issue 2607
Change-Id: Ib4db351d39f85d57ccf532da4d6422bdcbb88105
Remove "Click to" from topic edit button's tooltip

Making it more consistent with the tooltips on the other
buttons.

Change-Id: I3f26b08866452eb666da2a23be7201528b5f81a7
Describe issue tracker system integration in project owner guide

Change-Id: I19e521b74f91d6469775b955495613ce0b2eda93
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Improve/extend documentation about branch administration

Link this documentation from the project owner guide.

Change-Id: Ib487f10e48da2b601026696bd7642976bd2bb970
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Acceptance-tests: Fix 'Address already in use' bug

This change fixes ephemeral port assignment for HTTP and SSH daemons.

Current implementation is broken: it assigns a random port in GerritServer,
closes the socket and effectively freeing it for the kernel to recycle to
another thread, and store that port in gerrit.config file for reuse. Some
time later in HTTP and SSH daemons the port number get read from the config
file and the ports are bound.  The problem is, that during this "think time"
another test got the same port assigned and bind attempt is failing with:

  Caused by: java.net.BindException: Address already in use

To rectify it, set port to 0 in gerrit.config for both HTTP and SSH daemons
and let the daemons to do the ephemeral port assignments.  In SSH and HTTP
daemons this special case is recognized and the assigned ports are written
back to gerrit.config to pass to the test harness side.

Change-Id: Ib4971b200d6dc86268674398fe590137ae35b6f3
Merge changes I441995ea,I6668f619 into stable-2.8

* changes:
  Update sshd to 0.11.0
  Bump SSHD version to 0.10.1 and enable nio2 backend
Merge changes Ic339f766,Iaf2dad48

* changes:
  Buck: Add support for groups of acceptance tests
  Buck: Simplify acceptance_tests rule invocation
Merge "Acceptance-tests: Fix 'Address already in use' bug"