Dedup devref on unit tests

We already have a document on how to run unit tests, so
development.environment should just point to that document instead of
trying to summarize it.  Keeping this information in one less places
makes it easier to make sure the page is up to date (which
development.environment is not -- no mention of tox).

Change-Id: I9aecf439b6145b035b3457559ddb187058f5057b
Improve conductor error cases when unshelving

This commit handles different cases when the key 'shelved_image_id'
is not defined or None. Also it tries to improve the error messages.

Closes-Bug: #1307416
Change-Id: Ia2d0a183eefccdfd6f612d86f60cd2930c1a4b23
Remove and block DB access in dhcpbridge

This fixes an issue of direct DB access from happening in dhcpbridge
by using an object method instead. For this to work and to prohibit
future DB access from happening, the objects indirection API is set
and DB access is blocked in a similar way to how it is done in
nova-compute and nova-network.

Change-Id: I5e3152aad13343a6a1ecd9b5b511429159c9d4c2
Closes-Bug: #1316074
Improve hacking rule to avoid author markers

The case with the tag "moduleauthor" is not handled when
checking to avoid author makers.
Also fix the position when the tag Author is used.

Change-Id: I17b07b9f5448f9cbb4c5705f655c5392316a6239
Closes-Bug: #1314176
Raise HTTPForbidden from os-floating-ips API rather than 404

The os-floating-ips extension was catching and handling a 404
and 403 in the same block and raising HTTPNotFound for both.

This change separates the 404 and 403 cases so HTTPForbidden
is returned in the 403 case.  For the 404 case, the test is
updated to raise the proper NovaException and a new test is
added for the 403 Forbidden case.

Change-Id: Id0daf2d61c6960d845d3b7980f96228fece41128
Remove unnecessary cleanup in test

The test test_rollback_live_migration_at_destination_correctly
makes use of a fake instance object. No need to clean this from
the database with db.instance_destroy.

This issue was also raised in:
https://review.openstack.org/#/c/90801/3/nova/tests/compute/test_compute.py

Change-Id: I66a9f60b9e7b2f69f79976c03e4e9ddcc5e02993
VMware: prevent image snapshot if no root disk defined

If there is no root disk defined then the snapshot should
throw an exception.

Change-Id: I0549b8ca9ba41b734277600cb66a74b27ca72d88
Related-bug: #1297605
Merge "Don't translate debug level logs in nova.compute"
Merge "Don't translate debug level logs in nova.objects"
Merge "Don't translate debug level logs in nova.cmd and nova.db"
Merge "Don't translate debug level logs in nova.cert, console and consoleauth"
Merge "Add fault wrapper for rescue function"
Merge "Raise descriptive error for over volume quota"
Merge "Raise HTTPForbidden from os-floating-ips API rather than 404"
Merge "Remove duplicated import in unit test"
Fix v3 API extension names for camelcase

Most v3 API names are camelcase, but few APIs are not.
This patch changes them to camelcase for the consistency.

Change-Id: I0dc6c23ffcdcf97fc52d3575d521692805ffd9e3
Closes-Bug: #1315597
Merge "Update block_device_info to contain swap and ephemeral disks"
Merge "Improve hacking rule to avoid author markers"
Merge "VMware: reduce unit test times"
Merge "libvirt: Stub O_DIRECT in test if not supported"