add edit for different data type