Hi Dan,

I made all the other changes you (and Xiao) suggested. Didn't totally
understand which variables you wanted inlined. I inlined all the keys,
because they are short. Also it cleaned up the look of the function. I kept
the values in variables as they were long and it's nice to see the encoded
values next to the raw values.

Thanks for the pointers on style.

Thanks
Suguna




On Fri, Apr 4, 2014 at 6:40 PM, Daniel Pupius <notifications@github.com>wrote:

> In test/test_RedisConnection.js:
>
> > @@ -317,3 +322,193 @@ exports.testCounts = function (test) {
> >    cacheInstance.connect()
> >  }
> >
> > +// Helper function to test all the scenarios of compression, off, on, and dual mode
> > +function runCommonTest(cacheInstancePut, cacheInstanceGet, test, compressionFlag) {
> > +  var bigDefer = Q.defer()
> > +  var longKey = 'longKey'
>
> I don't see too much value in these variables. The test would be easier to
> read if the strings were inlined. You don't get much more type safety.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/Medium/zcache/pull/58/files#r11319360>
> .
>