Partially re-add the secure coding aspects of 10806 (which was rolled back in 10857). Fundamentally, the code in theora_open is written in a non-secure manner prior to this fix. That the callers currently appear per Goober to use it correctly is not the issue. There is no way of enforcing that contract as to length of the string unless it is internally handled in the function. Also Goober's comment that all callers use string lengths of MAX_FILENAME_LEN is incorrect. Examples trivially found that use the separate define NAME_LENGTH, which could be changed in future.

git-svn-id: svn://svn.icculus.org/fs2open@10872 387891d4-d844-0410-90c0-e4c51a9137d3
Further tweak fix for Coverity 1093783 Uninitialized scalar variable, and remove redundant variable in opengl_light structure

git-svn-id: svn://svn.icculus.org/fs2open@10873 387891d4-d844-0410-90c0-e4c51a9137d3
Address clang warning - debugconsole/console.cpp:169:13: warning: declaration shadows a local variable [-Wshadow]

git-svn-id: svn://svn.icculus.org/fs2open@10874 387891d4-d844-0410-90c0-e4c51a9137d3
Address clang warning - ./ship/shipfx.h:202:6: warning: private field 'stage' is not used [-Wunused-private-field]

git-svn-id: svn://svn.icculus.org/fs2open@10875 387891d4-d844-0410-90c0-e4c51a9137d3
Address clang warning - ./ui/ui.h:291:7: warning: private field 'ignore_escape' is not used [-Wunused-private-field]

git-svn-id: svn://svn.icculus.org/fs2open@10876 387891d4-d844-0410-90c0-e4c51a9137d3
Address clang warning - object/collideshipweapon.cpp:258:17: warning: declaration shadows a local variable [-Wshadow]

git-svn-id: svn://svn.icculus.org/fs2open@10877 387891d4-d844-0410-90c0-e4c51a9137d3
From MageKing17: Patch for a small issue in briefing text color spans

git-svn-id: svn://svn.icculus.org/fs2open@10878 387891d4-d844-0410-90c0-e4c51a9137d3
Address clang warning - menuui/mainhallmenu.cpp:2141:9: warning: declaration shadows a local variable [-Wshadow]

git-svn-id: svn://svn.icculus.org/fs2open@10879 387891d4-d844-0410-90c0-e4c51a9137d3
From MageKing17: Removes redundant function call

git-svn-id: svn://svn.icculus.org/fs2open@10880 387891d4-d844-0410-90c0-e4c51a9137d3
Address clang warning - lab/lab.cpp:912:8: warning: declaration shadows a local variable [-Wshadow]

git-svn-id: svn://svn.icculus.org/fs2open@10881 387891d4-d844-0410-90c0-e4c51a9137d3
Fix unintended linebreak removal from 10880


git-svn-id: svn://svn.icculus.org/fs2open@10882 387891d4-d844-0410-90c0-e4c51a9137d3
Address clang warning - io/keycontrol.cpp:2504:7: warning: declaration shadows a local variable [-Wshadow]

git-svn-id: svn://svn.icculus.org/fs2open@10883 387891d4-d844-0410-90c0-e4c51a9137d3
Address clang warning - hud/hudtarget.cpp:7224:12: warning: declaration shadows a local variable [-Wshadow]

git-svn-id: svn://svn.icculus.org/fs2open@10884 387891d4-d844-0410-90c0-e4c51a9137d3
Address clang warnings - hud/hud.cpp:1310:3: warning: delete called on 'HudGauge' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]

git-svn-id: svn://svn.icculus.org/fs2open@10885 387891d4-d844-0410-90c0-e4c51a9137d3
From MageKing17: Patch for Mantis 3074: Correct mismatch between mission write and mission parse

git-svn-id: svn://svn.icculus.org/fs2open@10886 387891d4-d844-0410-90c0-e4c51a9137d3
Fix for Mantis 2960: Actually make sure that we're not performing invalid operations on a vector.


git-svn-id: svn://svn.icculus.org/fs2open@10887 387891d4-d844-0410-90c0-e4c51a9137d3