Please ALWYAS add a coment explaining what you've done.  This will help many people later on.  Think about it this way: you've already spent hours getting it to work.  Why not spend 2 more minutes to make it easily accessible to others and even yourself later on?  I personally think that we should reject code which is not commented.  Even code of experimental nature.  We should learn good habits and this is good practice for them.

Grigore


________________________________
From: Andrei Stefanescu [notifications@github.com]
Sent: Tuesday, March 04, 2014 7:15 PM
To: kframework/k
Subject: Re: [k] added support for iteration over sets and maps; fixed set concatenation ... (#268)


In src/javasources/KTool/src/org/kframework/backend/java/builtins/BuiltinSetOperations.java:

> @@ -15,6 +16,21 @@
>   */
>  public class BuiltinSetOperations {
>
> +    public static BuiltinSet construct(BuiltinSet term1, BuiltinSet term2, TermContext context) {
> +        Variable frame = null;
> +        if (term1.hasFrame() && term2.hasFrame()) {
> +            throw new IllegalArgumentException("both map arguments have frames");


Yes, this is correct. I think this follows from the design of the data structure classes, but if you want I can add a comment here.

—
Reply to this email directly or view it on GitHub<https://github.com/kframework/k/pull/268/files#r10284022>.