Removed minor dead stores, to fix warnings

Change-Id: I7f24245fcebe8949d8028a15a85254970c42dbd9
Refactor to make intent clear to clang analyzer

It warned that ‘ext’ could be used uninitialized.
It didn’t see that the test after the for loop was testing
if the loop got all the way to the end without breaking.
Added bool instead to be explicit about it.

Change-Id: I006d1b3794e596ee08226b2c3f9167cccc145cc7
Fixed warning about possible null deref

Presumably ‘producer’ can never be null because
it’s unconditionally dereferenced a few lines below
this change.

Change-Id: I85c425ae1eaa17cf56118b90472412bec1c705c9
Fix clang analyzer warning by adding temp variable

With this temporary, it realizes the ?: and switch
branches are really making the same tests.

Change-Id: I14aa9e1612d64197d339048ec6bf3990655ea336
Fixed warning about using ‘volBounds’ uninitialized

It didn’t see that the loop should always be entered
at least once.  The loop was special-casing the
first iteration; pulled that out.

I think this is more readable anyway.

Change-Id: I96492639a267be13f234a5f051dafa6d3997d83e
ENH: Restore / convert Infovis examples

The infovis examples were never updated to VTK6. This patch restores
those examples and updates them to work with VTK6.

Change-Id: I29354858983c9a1198a0a40a2552e75d7e2ac62a
Signed-off-by: Andrew Maclean <andrew.amaclean@gmail.com>
ENH: Restore missing Infovis classes

A number of classes in Infovis/Core were not being compiled. This patch:
1) Moves vtkConvexHull2D and vtkGraphAnnotatedLayersFilter to
Rendering/Annotation.
2) Reinstates tests for vtkConvexHull2D, vtkDotProductSimilarity,
vtkArrayNorm
3) Removes unused test for TestTimePoint. The vtkTimePointUtility is
already tested in Common/Core.

Change-Id: I51c23a20897590531435f784602570865ebcb22b
Improve picking support in OpenGL2

Point association picking was not implemented this patch
adds that in. Also cell picking did not work when the input
contained quads or higher vertex count polygons.  To address
these issues the picking process needs to give the mapper an
opporunity to map the index from the frame buffer back into
a point id or cell id. Added amvirtual method in prop to
do that and an implementation in OpenGLActor and
OpenGLPolyDataMapper to properly map gl_PrimativeId in
the correct point or cell id.

Point picking was not tested in VTK so I added a test for
that as well.

Change-Id: If276e80ab3966646dd9f6f95fbc7734c006f000c
Merge topic 'point_picking' into master

c1eac93b Improve picking support in OpenGL2
Merge topic 'update-vtk-20141202' into pv-master

92420715 Merge topic 'fix-hdf5-cmake' into master
ca540cb3 hdf5: check for the right policy
c70ca401 Merge topic 'opengles3' into master
8aef7c2b Add in support for OpenGL ES 3.0
75c1a33e Merge topic 'volume_update_test' into master
40c6ad1d Merge topic 'basic-gles3-support' into master
b187a76a Merge topic 'even-more-clang-analzyer' into master
a5c4a9a7 Fixed memory leaks and malloc(0)
14c4790c Fixed null deref by returning upon error
e3337306 Fixed obvious dead stores
33dde16e Fixed null deref and whitespace/indentation
ba931533 Prevent null dereferences
845c2495 Remove a likely dead store
9d6d565c Suppress numerous warnings about using uninitialized memory
6fd5a5d5 Removed dead stores
2bacee00 Removed dead store to ‘j’
...
Merge remote-tracking branch 'pvvtk/pv-master' into HEAD

* pvvtk/pv-master:

Change-Id: I2b2b4cef2c3a8bbdc4b7fffa6fe02f91c77bc84a
Merge topic 'analyzer-warnings3' into master

af2526da Fixed warning about using ‘volBounds’ uninitialized
3099508a Fix clang analyzer warning by adding temp variable
92f6a354 Fixed warning about possible null deref
6e773e1d Refactor to make intent clear to clang analyzer
68294b7d Removed minor dead stores, to fix warnings
ENH: Unit Test FunctionParser

A unit test to cover almost 100% of a critical module.
With current patch, 95% coverage.

While building this unit test, repaired and enhanced:
vtkFunctionParser
  1) More consistent error messages
  2) Pow error checking wrong
  3) Removed unreachable code
vtkTestErrorObserver
  1) Accumulates error/warning messages until cleared. Prior behaviour
     was to only report last error/warning.

Change-Id: I62d011fcda5a097943553316b68334c406b87cfe
Only react to NSView frame changes if VTK itself created the NSView

Without this, VTK will change the size of the NSWindow, which apps
that create their own NSView and NSWindow and merely use VTK to draw into
them might not want/expect.

Fixes a regression I added in I3eb86e9982caae464fffe1c8cfc19035a194ec27
related to bug #14266.

Also added a public getter for the ViewCreated flag.
Also use getters in PrintSelf, since everything there was done getters.

Change-Id: I13ede32d361f9b17e11b8b0b37ad1997a864bf40
Merge topic 'UnitTestFunctionParser' into master

5f3f8374 ENH: Unit Test FunctionParser
Merge topic 'NSView-observation-fix' into master

fca2fd59 Only react to NSView frame changes if VTK itself created the NSView
Merge topic 'RestoreInfovisExamples' into master

0a0ff7af ENH: Restore / convert Infovis examples
Merge topic 'MissingInfovisClasses' into master

bac2c9cf ENH: Restore missing Infovis classes