I'm wondering if we should have tests for checking that we assign the attributes correctly for each channel type, I don't think we've covered that.