Adds support for gradle
Merge pull request #1 from KeepSafe/master

Adds support for gradle
Update license linter configuration

Summary: The Phab team broke the old `getConfig` for reading settings. Replace with new flow.

Test Plan: `arc lint` on a file with license linting configured.

Reviewers: mpellegrino, jmillard

Reviewed By: jmillard

Subscribers: mbishop

Differential Revision: https://devportal.imobile3.com/D9223
Update `xctool` to v0.1.15

Summary: Bumped `xctool` for a variety of reasons: https://github.com/facebook/xctool/releases/tag/v0.1.15

Test Plan: None.

Reviewers: ablackwood, gbeaman

Reviewed By: gbeaman

Subscribers: mbishop

Differential Revision: https://devportal.imobile3.com/D9225
Fixed license linter

Summary: `ArcanistWorkingCopyIdentity.getConfig()` has been replaced by more specific config retireval methods. This changes the using the appropriate new method.

Test Plan: Run the linter.

Reviewers: mbishop

Reviewed By: mbishop

Subscribers: jstarke, mbishop

Differential Revision: https://devportal.imobile3.com/D9914
Base unit test engine deprecation update

Summary: The Phabricator developers deprecated `ArcanistBaseUnitTestEngine` with `ArcanistUnitTestEngine` -- simple update since all functionality carries through.

Test Plan: None.

Reviewers: jmillard, mportune, ablackwood

Reviewed By: ablackwood

Subscribers: mbishop

Differential Revision: https://devportal.imobile3.com/D10561
Line length advice to 120 chars

Summary: Line length advice at 120 chars for android now.

Test Plan: NA

Reviewers: jmillard, mbishop

Reviewed By: mbishop

Subscribers: mbishop

Differential Revision: https://devportal.imobile3.com/D10663
Fixed Gradle linting

Summary: Fixed the linter for Gradle projects. In addition to plain not being broken anymore, it will now also detect individually which modules in a gradle project have been modified and will lint them each individually. This means that non-modified modules (which are often libraries) won't be linted every time. Since the linting is at the module level now, modules with many flavors will also lint significantly faster.

Test Plan: Lint a Gradle project and an Eclipse project.

Reviewers: mbishop, mportune, jstarke

Reviewed By: jstarke

Subscribers: mbishop

Maniphest Tasks: T3591

Differential Revision: https://devportal.imobile3.com/D11064
Fix for Android Lint bug

Apparently the Gradle wrapper script doesn't like `exec_manual`'s formatting. Also fixed not detecting errors running Gradle lint.
Bump xctool to v0.2.1 for Xcode 6 support
Removed "p" prefix lint rule

Summary: Android Studio only supports a single variable prefix for member variables. Having both the "m" prefix and the "p" prefix for member variables was causing automatic renaming and other things to not work correctly in Android Studio, so it is being removed. All non-static private and protected variables will now use the "m" prefix.

Test Plan: View unit test results.

Reviewers: mbishop, mportune, jstarke

Reviewed By: jstarke

Subscribers: mbishop

Differential Revision: https://devportal.imobile3.com/D11115
Change object directory detection logic. Use derived directory instead of hardcoded value
Merge pull request #3 from Tabbedout/update_directory_detection

Change detection logic for Objects-normal directory
Pull and merge with upstream