Thanks a lot.
Andrea

-------------------------------------------------------
Andrea Giammanco
Office phone:    +32 10 478185
Mobiles: +32 493 581662 (BE), +41 76 2323672 (CH), +39 349 5552471 (IT), +972 546307196 (IL)
________________________________
From: Vlandr57 [notifications@github.com]
Sent: 17 March 2014 12:37
To: cms-sw/cmssw
Cc: Andrea Giammanco
Subject: Re: [cmssw] Fast shower01 (#2886)


In FastSimulation/CaloHitMakers/src/EcalHitMaker.cc:

> @@ -387,7 +387,7 @@
>                 else
>                   {
>                     double x0=segiterator->x0FromCm(dist);
> -                   if(x0<maxX0_) maxX0_=x0;
> +                   if(x0>maxX0_) maxX0_=x0;


This change was introduced by Maxime Gouzevitch and his comment below:

This is a feature. Those lines was designed to decide if a detailed shower tail
shall be used or not. It is a question of speed vs details. It looks like in
version before a detailed shower tail was always called and the condiotion line 390
was useless. Now it allow to decide if one need or not detailed shower tail.

Florian may explain better the point why those lines have to be changed:

—
Reply to this email directly or view it on GitHub<https://github.com/cms-sw/cmssw/pull/2886/files#r10652815>.