QA: update RSpec assertions for modern syntax

This patch updates all the assertions and Then steps
for modern syntax.

It also changes a few other things, like adding "should"
to Then steps in Feature files and removing "should" from
Given steps where they do not belong.

And it removes a couple of unnecessary steps for efficiency

Change-Id: I392826b5326105f4042e1fbb893ad6645ee82715