Infact, storm python script doesn't use JAVA_HEAP_MAX. The .cmd files use
JAVA_HEAP_MAX as childopts value. If required, we could consider new
variable for childopts. My concern is....does JAVA_HEAP_MAX required ? If
required, how could we run storm daemons with both JAVA_HEAP_MAX and
chilopts value specified on the command line..as they both seem to be in
same format as .. -Xmx%%%m


On Tue, May 6, 2014 at 8:39 PM, Robert (Bobby) Evans <
notifications@github.com> wrote:

> In bin/storm.cmd:
>
> > @@ -106,6 +106,12 @@
> >  :drpc
> >    set CLASS=backtype.storm.daemon.drpc
> >    set STORM_OPTS=%STORM_SERVER_OPTS% %STORM_OPTS%
> > +  %JAVA% -client -Dstorm.options= -Dstorm.conf.file= -cp %CLASSPATH% backtype.storm.command.config_value drpc.childopts > temp.txt
> > +  FOR /F "tokens=1,* delims= " %%i in (temp.txt) do (
> > +     if %%i == VALUE: (
> > + 	set JAVA_HEAP_MAX=%%j )
>
> Why JAVA_HEAP_MAX? I can see that it works, but it is not an intuitive
> place to put them at all. And what happens if someone else sets
> JAVA_HEAP_MAX. This will stomp on it.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/apache/incubator-storm/pull/102/files#r12329242>
> .
>