edit-node: need get the basename of install plugin pkg

Change-Id: I6725fdaacc65eb0e2bd0f50e80cbc6aab81731f4
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1026635
Signed-off-by: hadong <hadong0720@gmail.com>
Add if statement to avoid duplicate elements in "funcs" list

Change-Id: I1c1aabe95c4cae1b88fbca3dad62c19d61d19335
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1023700
Signed-off-by: hadong <hadong0720@gmail.com>
Basic sanity checking for user input to edit-node

Previously, edit-node didn't verify whether input was actually
RPMs or appeared to be yum repositories. Add these checks.

Change-Id: I05995fa62038db92b43939d087dcb9dcdcce5175
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=993525
Signed-off-by: Ryan Barry <rbarry@redhat.com>
update dracut module patches in ovirt-node %post

rhbz#1031975

Change-Id: I0a41ec3179166b4d4653b68346acba40ca8acc6e
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
installer Fix multipath device detection

Previously the installation could fail in specififc multipath setups.
This is now fixed by a better multipath -l output parsing.

Change-Id: I079f565aa88fe2f9bb54addb5db774240e08b733
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
Disable multipath for install, but leave it otherwise

Previously, using multipath-capable devices for the install
sometimes paniced without being able to find root. With the
addition of an option to dracut to disable it, we now remove
multipath support during the install phase, but leave it in the
bootloader arguments for normal booting

Change-Id: Ie5a3fa380c6561669dab843e14ae320d5fb4f3a2
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=856877
Signed-off-by: Ryan Barry <rbarry@redhat.com>
process: Add a masking log

Previously there was no way to mask out parts of a command which was
run. This could lead to situations where sensitive informations like
passwords/usernames/addresses/etc. were exposed. To prevent this
situation now a context manager is available to hide sensitive
informations in command calls.

Example:

>>> import process
>>> pw = "secret"
>>> with masked([pw]):
...     process.call(["app", "--user", "foo", "--password", pw])

In that example only
["app", "--user", "foo", "--password", "<masked>"]
will get logged.

Change-Id: I013e79b006c24e475f8f021c76a5156520145bfd
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
Clean up kdump page

Hide the implementation details of the kdump model in the model
itself, so we don't need to worry about passing the correct
number of arguments every time they change, and we can use have a
more logical flow in the view itself.

Change-Id: I2b1fe1c2303aa022e0064e431f930d5fc9226bec
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=991375
Signed-off-by: Ryan Barry <rbarry@redhat.com>
Make sure plugin autoinstall files stay in their packages

Tweak the specfile a bit to make sure new plugins with autoinstall
directives don't leak files back into ovirt-node.

Change-Id: I036b8b37dd63b1b6126cfe2af72f2ef3f6a3afc8
Signed-off-by: Ryan Barry <rbarry@redhat.com>
Validate "Other Device" against live device

Previously, we didn't check whether or not "Other Device" input
matched against a known live device or not (USB boot, etc). Do so.
As part of this, slight rearrangement of storage.Device to improve
responsiveness when looking for udev devices (we're assuming udev
will not change during the install), and get the new validation
workflow to properly invalid pages if a plugin's on_change throws
an exception.

Change-Id: I44b87876876965418765cbb6a0c0030bf143f156
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=885017
Signed-off-by: Ryan Barry <rbarry@redhat.com>
Add utils.system.Bootloader

Add a class for manipulating GRUB arguments.

Change-Id: I5a796a4c07bd99b927070ec62a7b1d990d4e1f9b
Signed-off-by: Ryan Barry <rbarry@redhat.com>
config: Improve resolv.conf comment

resolv.conf is managed through Engine when Node is managed.

Change-Id: I31c21035051b0054732a0071be1033e1de00420e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=953705
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
add fallback method for older udev version for nic vendor

rhbz#978226

Change-Id: Ie2f6420f3204100afc2230661f56c26e92c2aebf
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
Make Entry fields scroll when input exceeds max columns

Previously, when a user input a value longer than the TUI could
display, the excess was clipped not visible. Be smarter about how
we display it to users.

Change-Id: Ica8768fa011fcfdbef19251d313bc4b1cc0c8a6b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=981189
Signed-off-by: Ryan Barry <rbarry@redhat.com>
valid: Don't allow leading zeros for numbers

Change-Id: Icd3500b2e4ae313ea84c1250aa3a490ae4e5baec
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=984343
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
Edit-node cleanup -- remove duplicate code paths

Remove duplicate code paths and cleanup code slightly.

Change-Id: If37be3dbf2db1f1dc7d413e381695e927878bc97
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=988672
Signed-off-by: Ryan Barry <rbarry@redhat.com>
Show infinity instead of None for bounds in valid.Number

Previously, specifying None at either end of the bounds for a
Number validator would return a message which showed that it must
be within [0, None] instead of infinity. Show a more logical
result.

Change-Id: Ic2a2eba3e33d4354677cfa254a2a3e18c59ef813
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=989398
Signed-off-by: Ryan Barry <rbarry@redhat.com>