make prefs an instance var in generatorserviceimpl, rather than passing it as an arg
extract populatePoolsByType() from generatroserviceimpl constructor
add complete mock prefbean object
refactor PasswordController for readability
tidies code in generatorserviceimpl
cleanup code in generatorserviceimpl