WINDUP-167: Check for duplicate @TypeValues

Might have been due to an unproxiable exception type?


On Fri, Aug 15, 2014 at 12:14 PM, Jesse Sightler <notifications@github.com>
wrote:

> In
> graph/tests/src/test/java/org/jboss/windup/graph/duplicate/typevalue/DuplicateTypeValueTest.java:
>
> > @@ -40,16 +38,12 @@ public static ForgeArchive getDeployment()
> >      @Inject
> >      private GraphContext context;
> >
> > -    @Ignore("Until WINDUP-167 is done.")
> > -    @Test
> > +    @Test(expected=Exception.class)
> >      public void testDuplicateTypeValue() throws Exception
>
> I agree, although at the time of this patch I tried that and it didn't
> really work.
> … <#147da72fe3d945d6_>
> On Aug 15, 2014 11:32 AM, "Lincoln Baxter, III" <notifications@github.com>
> wrote: In
> graph/tests/src/test/java/org/jboss/windup/graph/duplicate/typevalue/DuplicateTypeValueTest.java:
> > @@ -40,16 +38,12 @@ public static ForgeArchive getDeployment() > @Inject
> <https://github.com/Inject> > private GraphContext context; > > - @Ignore
> <https://github.com/Ignore>("Until WINDUP-167 is done.") > - @Test
> <https://github.com/Test> > + @Test <https://github.com/Test>(expected=Exception.class)
> > public void testDuplicateTypeValue() throws Exception Yes. Expecting a
> narrower exception type is probably a good idea here. — Reply to this email
> directly or view it on GitHub <
> https://github.com/windup/windup/pull/184/files#r16298108>.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/windup/windup/pull/184/files#r16300514>.
>



-- 
Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."