It's supposed to return if INHERIT is found in the list. Test should fail
if the loop is completed. Unless I didn't understand the last line of that
test.
On Feb 26, 2014 12:24 AM, "Patrick Lauber" <notifications@github.com> wrote:

> In cms/tests/settings.py:
>
> > @@ -27,3 +28,22 @@ def test_invalid_language_code(self):
> >                  ImproperlyConfigured,
> >                  get_cms_setting, 'LANGUAGES'
> >              )
> > +
> > +    def test_create_page_with_inheritance_override(self):
> > +        with SettingsOverride(CMS_TEMPLATE_INHERITANCE=True):
> > +            for template in get_cms_setting('TEMPLATES'):
> > +                if (template[0] == constants.TEMPLATE_INHERITANCE_MAGIC):
> > +                    return
>
> not sure this test works as intended because of the return. use
> self.assert... something here.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/divio/django-cms/pull/2731/files#r10071350>
> .
>