Fix Rubocop violations

[#65117796]

Signed-off-by: Ruth Byers <rbyers@pivotallabs.com>
Introduce Rubocop

All violations have currently been added as exceptions to rubocop-todo.yml

[#65117796]

Signed-off-by: Ruth Byers <rbyers@pivotallabs.com>
Ignore vendor directory during Rubocop run

[#65117796]

Signed-off-by: Ruth Byers <rbyers@pivotallabs.com>
Switch alias to alias_method

* Appeases Rubocop Alias cop.

[#65117796]

Signed-off-by: Ruth Byers <rbyers@pivotallabs.com>
Remove extraneous presenter spec fixtures.

Signed-off-by: Ruth Byers <rbyers@pivotallabs.com>
Fix AmbiguousOperator Rubocop warnings.

* Remove outdated bin/setup_yeti script.

Signed-off-by: Ruth Byers <rbyers@pivotallabs.com>
Remove all assignments in conditionals.

* Addresses AssignmentInCondition Rubocop rule.

Signed-off-by: Ruth Byers <rbyers@pivotallabs.com>
Reorganize Rubocop TODO file.

Signed-off-by: Ruth Byers <rbyers@pivotallabs.com>
Add configuration option to enable writing billing events

* Default is to enable billing.
* Config#merge_defaults now public and tested.
* Ensure event writing is enabled in specs that check billing-event state.

[#64327074]

Signed-off-by: Ruth Byers <rbyers@pivotallabs.com>
Add routes list scoped to space

[#62595002]

Signed-off-by: Maria Shaldibina <mariash@pivotallabs.com>
Remove obsolete controller collection tests

* one_to_many_collection_ids_without_url group no longer used.

Signed-off-by: Maria Shaldibina <mariash@pivotallabs.com>
Remove unused properties from minimal config

Signed-off-by: Maria Shaldibina <mariash@pivotallabs.com>
Use request timeout from config as thin timeout

[#64937906]

Signed-off-by: Maria Shaldibina <mariash@pivotallabs.com>