Alter execute_alembic_command() to not assume all commands

Alembic 0.7.1 is adding new diff directives add_fk and remove_fk.
The logic in execute_alembic_command() appears to assume all potential
commands are present in METHODS.   This patch adjusts it so that
it checks METHODS first, allowing the tests in neutron.tests.unit.db.test_migration
to pass.  However, if the design here requires that all potential
Alembic commands are handled, then this would not be the fix,
though I recommend that the potential list of Alembic directives
not be hardcoded.

Change-Id: Ib08685be252e1fdb0f10853f8fc9a7e19ac54a94
Closes-Bug: #1397796
pretty_tox.sh: Portablity improvement

A recent change (commit 0d5a11d9c722870f9c5e31a993219c7e240b4e19)
introduced bash dependency.  It broke my environment, where bash
is not available.  This change aims to restore it.

As far as I undestand, the change in question requires bash for
the "pipefail" feature.  Fortunately there's a more portable
well-known trick for the purpose.

Closes-Bug: #1398266
Change-Id: Id3561d81462923d20ad39584ba4cf8e1a294a8a8
Updated the README.rst

Updated the Readme.rst with some formatting issues. Also
stole the ending line from the Nova to point in the direction
of the CONTRIBUTING.rst.

Change-Id: I595b7feb641aee91d47ba55eedab29e7511bfa35
Remove ovs-vsctl call from OVSInterfaceDriver

ovs_lib module is responsible for the interaction with OVS but
OVSInterfaceDriver._ovs_add_port() method calls directly
ovs-vsctl which implies inconsistencies: ovs_lib calls ovs-vsctl
with a timeout but not OVSInterfaceDriver._ovs_add_port().

This change moves ovs-vsctl call in OVSInterfaceDriver._ovs_add_port
to ovs_lib.

Closes-Bug: #1396489
Change-Id: I4d03f8beef2c5f2366ad2d1cf5f0b18b4f2857cd
Enforce log hints in neutron.plugins.plumgrid

This change enforces log hints use and removes debug level log
translation, modifications are validated through a hacking rule and
the change respects loggging guidelines.

Validate that hacking rules apply to directories:
    - neutron/plugins/plumgrid

Change-Id: Ie85abb93cdbe50bdd56c9f987784baf4c4dd631d
Partial-bug: #1320867
Update i18n translation for Embrane plugin

All the existing LOG.info, LOG.warning, LOG.error and LOG.critical
messages should have _LI, _LW, _LE and _LC respectively. Also, debug
level log shouldn't be translated. This patch set will cover the
embrane directory.

Change-Id: I89cf8e63311f96c3f1759a6c885d1b98e6fed598
Partial-Bug: #1320867
Update i18n translation for Nuage plugin

Ensure that the LOG hacking rules are enforced on the nuage plugin
directory.

Change-Id: I0a415dfdf81ad337eda0dc8b618b6125b938a1eb
Update i18n translation for Brocade plugin log msg's

All the log messages now have the required hints. In addition to
this debug messages are not translated.

This is done for the plugins/brocade directory.

Change-Id: I2ac926fd72037bb8f0605267ad50472c447ae83d
Update i18n translation for Metaplugin plugin

All the existing LOG.info, LOG.warning, LOG.error and LOG.critical
messages should have _LI, _LW, _LE and _LC respectively. Also, debug
level log shouldn't be translated. This patch set will cover the
metaplugin directory.

Change-Id: I34437019fc8ffc38f11114d1d83dce54170ab989
Partial-Bug: #1320867
Enforce log hints in opencontrail

This change enforces log hints use and removes debug level log
translation, modifications are validated through a hacking rule
and the change respects loggging guidelines. Validate that hacking
rules apply to directories:- neutron/plugins/opencontrail

Change-Id: I44f215a672c08c7f0046bc026abe7c6a5d1697d1
Partial-bug: #1320867
Fix program name in --version output

Neutron currently outputs something like

---
$ neutron-server --version
%prog 11.el7ost
---

I'm guessing since Ied2acb37c366f1a45aed72b6b76f11e2de23828e when
oslo.config moved from optparse to argparse?

Change-Id: Ie51d2d1263a215390e106201b35902d6c401506d
Merge "Alter execute_alembic_command() to not assume all commands"
Fix enable_metadata_network flag

The following patch: 9569b2fe broke the desired functionality of
the enable_metadata_network flag, by not allowing the metadata
proxy to be spawn for 'metadata networks', which are used for
accessing the metadata service when the logical router is not
implemented through the l3 agent.

This patch enables spawning of the metadata proxy for metadata
networks when the appropriate flag is set to True.

The patch also adds rather pedant unit test coverage for the
should_enable_metadata method which previously had no unit test.

Change-Id: I8dca1fce9fbc83e75ba7e4ce948531427bf7e88b
Closes-bug: 1394020
Imported Translations from Transifex

For more information about this automatic import see:
https://wiki.openstack.org/wiki/Translations/Infrastructure

Change-Id: Ic0f2297c07cfc9dcef66df980b2615beac8cb173
Merge "Enforce log hints in opencontrail"
Get rid of py26 references: OrderedDict, httplib, xml testing

Change-Id: I44315e0663a7c0c82110b933b68e2b747f548859
Cleanup recent generalization in post mortem debugger

Remove unnecessary default arguments and constants in
the post mortem debugger code.

Also remove exception internationalization in testing code.

Change-Id: I66ba3248a7ff502fa92e1c46f40e280c503524a2
Remove RpcProxy class

All users of this class have now been converted to use oslo.messaging
APIs directly, so this compatibility class can be removed.

Part of blueprint drop-rpc-compat.

Change-Id: Ife5c96d2d737694b9e79fe079d62dc48f23c033a
Fix up an old RpcProxy assumption

This patch fixes one last bit of code that assumed that the base
PluginApi used RpcProxy.  This code is now fixed to use the proper
oslo.messaging APIs instead.

Part of blueprint drop-rpc-compat.

Change-Id: I4adc321c07e6b5ad45a01f163b4c7e1ab74bcafd
Convert several uses of RpcCallback

Convert several places in the code that were using the RpcCallback
compatibility class.  This class eased the transition to
oslo.messaging.  This patch drops the usage of this class in favor of
direct usage of the appropriate oslo.messaging API.

Part of blueprint drop-rpc-compat.

Change-Id: I955958e836635d43dabc7b39d050c1418b18cf8f