I understand you use Felix. I was just mentioning that we use Google here
since it is more detailed. According to your code, you are not following
Felix either. Maybe just a few picked out. The ones not being used are:
- 80 chars per line.
- Single quotes
- One variable per var statement.
- Camelcase
- Using the "===" operator
- Naming your closures
- Need to change comments to slashes

I fixed the quotes and the use of semi colons. If you have any specific
preferences on code styling, I suggest you make them yourself or create a
required style guide for contributing. Otherwise you can just re-style
yourself after it is in the codebase. Would be kind of hard to make every
contributor conform to a style that is not defined.

I am not going to go back and format something as trivial as styling
preferences while contributing when those styles are not defined upfront.
If you don't want the code, don't take it. ;)


On Mon, Apr 14, 2014 at 10:23 AM, Charles Pick <notifications@github.com>wrote:

> In test/server/server-test.js:
>
> > @@ -1,101 +1,103 @@
> > -var errors = LIB.errors;
>
> @nitrog7 <https://github.com/nitrog7> the project doesn't use Google's
> style guide, it uses felix's <https://github.com/felixge/node-style-guide>,
> which doesn't cover this. Anyway, I would like to stick with the
> conventions already present in the code. JSHint should be used to catch
> syntax errors, missing semi colons etc, not enforce coding style. We don't
> need to "use strict" everywhere. I don't think it's a barrier to
> contribution anyway, just take a look at the existing coding style and copy
> it.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/codemix/oriento/pull/24/files#r11586399>
> .
>