Sounds quite reasonable. How about a check at load time, i.e., qe-><Model
Name> == m->model_impl()?


On Fri, Feb 7, 2014 at 12:08 PM, Robert Carlsen <notifications@github.com>wrote:

> In src/Models/BatchReactor/batch_reactor_tests.cc:
>
> > @@ -206,7 +205,7 @@ void BatchReactorTest::TestInitState(BatchReactor* fac) {
> >  //- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
> >  TEST_F(BatchReactorTest, XMLInit) {
> >    std::stringstream ss;
> > -  ss << "<start>"
> > +  ss << "<start><name>fooname</name><UNSPECIFIED>"
>
> The way the code is set up, the model_impl_ is set during the xml
> initialization process. So unless we run through the xml_file_loader (yuck)
> to init a model, or we manually call SetModelImpl (yuck) it doesn't get
> set. I think we should probably move to making model_impl a pure virtual
> method that all concrete models implement:
>
> virtual model_impl() {return "MyFooModel";};
>
> Then it is always correct regardless of initialization method/process.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/cyclus/cycamore/pull/180/files#r9548498>
> .
>



-- 
Matthew Gidden
Ph.D. Candidate, Nuclear Engineering
The University of Wisconsin -- Madison
Ph. 225.892.3192