OCSADV-154 Update TOO target/guide to take real magnitudes

This is more fallout from removing the `brightness` string, which it turns out was used by the TOO servlet.

- Added `ImList<Magnitude> getMagnitudes()` as a member to `TooTarget`, and changed `TooUpdateServiceImpl` to propagate this information to the database.
- Added parser for magnitude lists like `1.2/UC/Jy,3.4/R/Vega`.
- Added code to `Http*` implementations of `TooTarget` to parse and retain a magnitude list.
- Refactored common `HttpTarget` superclass for `HttpTooTarget` and `HttpTooGuideTarget` just to get rid of some copy-paste. The refactored code looks kind of gross in the diff, sorry.
- Updated `README` to document the new request format. @swalker2m we need to notify the authorities of this change; not sure how to do this.


Yes, I'm barely scratching the surface of what you can do with ScalaCheck

Sent from my iPhone

On dic 11, 2014, at 15:14, "Rob Norris" <notifications@github.com<mailto:notifications@github.com>> wrote:


In bundle/edu.gemini.oodb.too.url/src/test/scala/edu/gemini/spdb/rapidtoo/www/HttpTargetSpec.scala<https://github.com/gemini-hlsw/ocs/pull/170#discussion-diff-21695349>:

> +import java.util.Locale
> +import javax.servlet.{RequestDispatcher, ServletInputStream}
> +import javax.servlet.http.{Cookie, HttpSession, HttpServletRequest}
> +
> +import edu.gemini.shared.skyobject.Magnitude
> +import edu.gemini.spModel.core.{Angle, Declination, RightAscension}
> +import edu.gemini.spdb.rapidtoo.TooGuideTarget.GuideProbe
> +import edu.gemini.shared.util.immutable.ScalaConverters._
> +
> +import org.specs2.ScalaCheck
> +import org.specs2.mutable.Specification
> +import org.scalacheck.Arbitrary._
> +import org.scalacheck.Prop.forAll
> +import org.scalacheck.Prop._
> +
> +object HttpTargetSpec extends Specification with ScalaCheck with Arbitraries {


Maybe I should do a presentation on ScalaCheck, because it is awesome.

-
Reply to this email directly or view it on GitHub<https://github.com/gemini-hlsw/ocs/pull/170/files#r21695349>.