vm: improve the logging when destroying domains

The logging of the failures of the domain destruction
in releaseVm was messy and confusing.
This patch improve the logging and make sure that errors
aren't silently ignored.

Change-Id: Ib314ecd66bb7ccb95da96605d810041f767bc9e0
Signed-off-by: Francesco Romani <fromani@redhat.com>
Reviewed-on: http://gerrit.ovirt.org/28023
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
vm: narrow down try/except block in releaseVm

In releaseVm, we have a too wide try/except block;
only self._dom.destroy() can actually raise libvirtError,
so this patch narrows down the block size.

Change-Id: I9c2b60d8f490f9559edad429baf3989e98d05cf6
Signed-off-by: Francesco Romani <fromani@redhat.com>
Reviewed-on: http://gerrit.ovirt.org/28024
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
vm: abort and report error if domain destroy fails

The call of vm._dom.destroy() is not expected to fail.
However, if the failure is not impossible, and in
that case VDSM should detect that and report the
error instead of blindly go ahead.

This patch let releaseVm() bail out with an error
as soon as possible if destroy() fails.

Due to entanglement of the error floes, the more correct
way to handle this error conditions is also the nicer,
by splitting the destroy attempts into submethods.

Change-Id: Id6d5819321cd0cb28aa43678dc65ee83c215c2d7
Signed-off-by: Francesco Romani <fromani@redhat.com>
Reviewed-on: http://gerrit.ovirt.org/28025
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
tests: fix FakeGuestAgent field

fix guestIPs, which is supposed to be
"A space separated string of assigned IPv4 addresses"
and not a list.

Change-Id: If4d9822356b05a87a75ba4a0b097265b6760e0e4
Signed-off-by: Francesco Romani <fromani@redhat.com>
Reviewed-on: http://gerrit.ovirt.org/28801
Reviewed-by: Vinzenz Feenstra <vfeenstr@redhat.com>
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
Query interface for all VM fields

Change-Id: Iddb4657d738ca0406950d07b84a7c85721e80b78
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1083070
Signed-off-by: Vinzenz Feenstra <vfeenstr@redhat.com>