That test is not ready. That's why I put WIP in the PR. I was working on it
as an experiment to learn both AAE and CRDT code while waiting for jtuple
to finish up a strong consistency PR for 2.0 beta. I've since transitioned
and haven't worked on this at all. I may have some time next week. It's not
a critical test for RC, but is a nice to have for release.

I appreciate the comments. I didn't know that builtin existed and will use
it. As for the AAE, maybe there is a setting I can tune.


On Fri, May 23, 2014 at 7:54 PM, Sean Cribbs <notifications@github.com>wrote:

> In tests/verify_dt_aae_converge.erl:
>
> > +    fun(C) ->
> > +        riakc_counter:increment(Value, C)
> > +    end.
> > +
> > +verify_counter(RiakcPid, Expected) ->
> > +    verify_counter(RiakcPid, Expected, ?READ_OPTS).
> > +
> > +verify_counter(RiakcPid, Expected, ReadOpts) ->
> > +    {ok, Val} = riakc_pb_socket:fetch_type(RiakcPid,
> > +        {<<"counters">>, ?PB_BUCKET}, ?KEY, ReadOpts),
> > +    ?assertEqual(Expected, riakc_counter:value(Val)).
> > +
> > +create_pb_clients(Nodes) ->
> > +    [rt:pbc(N) || N <- Nodes].
> > +
> > +create_bucket_types([N1|_]=Nodes, Types) ->
>
> We wrote this in verify_dt_converge before
> rt:create_and_activate_bucket_type() existed. It is preferable to use the
> built-in.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/basho/riak_test/pull/557/files#r13023237>
> .
>