I'm not sure if that is safe in new Node or not, but doing a NanEscapeScope() is never wrong in this case, so better err on the safe side and use it. If it happens to be safe now it does not imply that it won't break in the future.

Rod Vagg <notifications@github.com> wrote:

In bignum.cc:

> @@ -850,33 +864,30 @@ BigNum::Bop(const Arguments& args, int op)
>    free(payload);
>    free(mask);
>  
> -  return scope.Close(result);
> +  return NanEscapeScope(result);
right, could you review afe0160 for me please @kkoopa? Can I just return NanUndefined() from within an EscapableScope do you think? It compiles and works on all relevant Node versions but is it correct and safe?

—
Reply to this email directly or view it on GitHub.