standardizing page managers

I wanted to add a fade transition in between pages, but I realized that it gave the impression that performance was slightly slower. So there is no transition added here; I just extracted the common functionality into the page_manager_mixin and brought the landing page controller in line with the other two.
Hi Roman,

I see how this looks messy . It is just supposed to check whether the new
sub page is different from the current one, and if they are the same, it
should not re-show that view. To be honest I'm not sure if the final check
is necessary, I just wanted to make sure to re-render the subview if it
wasn't in the dom already; perhaps I added that  before I decided to detach
the entire page and keep everything in memory.

On Sun, Nov 2, 2014 at 4:14 PM, Roman Chyla <notifications@github.com>
wrote:

> In src/js/page_managers/abstract_page_controller.js:
>
> >          if (!viewName) {
> >            console.warn("viewname undefined")
> >            return
> >          }
> >
> >          //tell router to display the correct subview only if it's not already there
> > -        if (!this.collection.subPage || this.collection.subPage.viewKey !== viewName || $("s-middle-col-container").children().length === 0){
> > +        if (!this.collection.subPage || this.collection.subPage.viewKey !== viewName || this.controllerView.$("s-middle-col-container").children().length === 0){
> >
> >            dataForRouter = "abs/" + this._bibcode + "/" + viewName;
> >
> >            this.pubsub.publish(this.pubsub.NAVIGATE_WITHOUT_TRIGGER, dataForRouter);
>
> let's revisit this - I need to understand this mechanism and currently i'm
> feeling uncomfortable seeing it here; because supposedly this abstract page
> is rendered because of some action that happens OUTSIDE of it
>
> and we are turning around the point of 'waht is the use of router'
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/adsabs/bumblebee/pull/139/files#r19714957>.
>