Dropping the selection markers manipulates the selection which plays

havoc in multiple scribe instances...

Chrome handles the selection fine but Firefox requires the manipulation.
The tests are still holding up. The previous works but it manipulates the
selection before actually using it, which is a problem in Chrome as it
seems to do its own manipulations before the updating the selection. I
can't see a reason for doing this before as we never used the markers
anyway.

On 9 October 2014 16:23, Sébastien Cevey <notifications@github.com> wrote:

> In src/plugins/core/events.js:
>
> > @@ -39,18 +39,17 @@ define([
> >          // We always want to do this because Chrome >= 38 does create the event
> >          // loop and doesn't leave things alone
> >          if (selection.range) {
> > -          selection.placeMarkers();
> > -          selection.removeMarkers();
>
> Was there a reason why we did this before? Is this going to break another
> use case?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/guardian/scribe/pull/264/files#r18652104>.
>

-- 

------------------------------
Visit theguardian.com. On your mobile and tablet, download the Guardian 
iPhone and Android apps theguardian.com/guardianapp and our tablet editions 
theguardian.com/editions.  Save up to 57% by subscribing to the Guardian 
and Observer - choose the papers you want and get full digital access. 
 Visit subscribe.theguardian.com

This e-mail and all attachments are confidential and may also be 
privileged. If you are not the named recipient, please notify the sender 
and delete the e-mail and all attachments immediately. Do not disclose the 
contents to another person. You may not use the information for any 
purpose, or store, or copy, it in any way.  Guardian News & Media Limited 
is not liable for any computer viruses or other material transmitted with 
or as part of this e-mail. You should employ virus checking software.
 
Guardian News & Media Limited is a member of Guardian Media Group plc. Registered 
Office: PO Box 68164, Kings Place, 90 York Way, London, N1P 2AP.  Registered 
in England Number 908396