doc generation now working