> One oversight is full-text search on Error messages that are longer than
100kb.

We store a "searchable body" metadata item for all messages including
failed ones => this enables free text search for them


On Tue, Feb 18, 2014 at 9:21 PM, Itamar Syn-Hershko <
notifications@github.com> wrote:

> In src/ServiceControl/Operations/BodyStorage/BodyStorageEnricher.cs:
>
> >                  message.Metadata.Add("BodyUrl", bodyUrl);
> >              }
> >
> > -            message.Metadata.Add("BodySize", bodySize);
> > +            if (!contentType.Contains("binary") && bodySize <= MaxBodySizeToStore)
> > +            {
> > +                message.Metadata.Add("Body", System.Text.Encoding.UTF8.GetString(message.PhysicalMessage.Body));
> > +            }
>
> One oversight is full-text search on Error messages that are longer than
> 100kb.
>
> The RavenDB issue is not really an issue - the byte array is going to be
> serialized to string anyway as the document is saved in string format, so
> all we are doing is handling that ourselves instead of letting RavenDB do
> that.
>
> The problems with attachments were 2-writes per message and the expiration
> bundle. If we only store error messages in attachments (infrequent and
> never expire) this makes sense, but the behavior isn't well-defined at this
> point.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/Particular/ServiceControl/pull/235/files#r9839945>
> .
>