Use create instead of make

  * Make may result in some test flakiness we see in travis

Signed-off-by: Michael Maximilien <maxim@us.ibm.com>
Don't create pidfile in runner spec

  * this might cause integration test to fail to start cc

Signed-off-by: Michael Maximilien <maxim@us.ibm.com>
Remove unused and confusing :raise_on_failure flag

The flag did not actually change any configuration, but was required for
some reason.

[#62026144]
Move broker api compat. tests to spec/acceptance

Before this, they were in spec/integration, but declared themselves to
be controller tests.

[#62026144]
Extract Catalog class into file and backfill tests

[#62026144]
Report a meaningful error when a broker returns a catalog with invalid
fields [#62026144]
Show all validation errors when broker returns an invalid catalog
[finishes #62026144]
Run integration and acceptance tests in the same process
Change CC thin server timeout to 5 minutes.

  * this should now match ELB and gorouter timeouts

[finishes #64592994]
Signed-off-by: Aram Price <aprice@pivotallabs.com>
Fix BackgroundJobEnvironment, add tests to it

[#64676414]

Signed-off-by: Kris Kelly <kkelly@pivotallabs.com>
Don't pollute STDOUT in tests

Signed-off-by: Kris Kelly <kkelly@pivotallabs.com>
Improve human readability for catalog errors. [#62854062]
Ensure fields in error messages refer to catalog field names as opposed
to db field names

[finishes #62854062]
Fix quotes

Signed-off-by: Michael Maximilien <maxim@us.ibm.com>
Add thread info to /varz

[#64680726]

Signed-off-by: Michael Maximilien <maxim@us.ibm.com>
Refactor spec for clarity

  * we now check instant setting of /varz data apart from deferred tasks

Signed-off-by: Michael Maximilien <maxim@us.ibm.com>
Fix quotes

Signed-off-by: Michael Maximilien <maxim@us.ibm.com>
Extract rack app building

So we can change it test-first [#64688246]

Signed-off-by: Eric Malm <emalm@pivotallabs.com>
Separate global config from rack app building

Looks like they were accidentally coupled [#64688246]

Signed-off-by: Eric Malm <emalm@pivotallabs.com>
Fix quotes and formatting

Signed-off-by: Michael Maximilien <maxim@us.ibm.com>