added setting editing