fix failing acceptance test and remove suppression sol11
Merge pull request #1846 from MatthewCattell/fix-failing-acceptance-test-sol-11

fix failing acceptance test and remove suppression sol11
Enable Ctrl-C to kill all sub processes on Windows.

...not just the test script itself. This will even kill stuck
processes such as cf-agent or cf-serverd. It does *not* work by
terminating the SSH connection yet though.
Do not alter environment CFLAGS, CPPFLAGS etc.

These variables should never be overriden by our makefiles, only the
AM_CFLAGS or libcf_agent_la_CFLAGS variants are to be set.

Also fixed wrong libutils dependencies that were discovered after this
change: libutils currently must link to OpenSSL and PCRE.

This clean-up occurred after an attempt to only link cf-upgrade to
libutils, but noticing that it pulls out everything as dependency.
CFLAGS, CPPFLAGS etc should override auto-detected variables.

CFLAGS, CPPFLAGS, LDFLAGS are the ones that user sets on the command
line by doing:

./configure CFLAGS=-O3

Thus they should stay the last ones, overriding all auto-detected values
and configure-specified values. This patch attempts to make this happen.

Nevertheless we still retain and manually append ENV_CFLAGS at the end
of CFLAGS.  Even though CFLAGS should contain the ./configure command
line CFLAGS as last, some macro seem to mess the order up and insert
its own optimisation flags as well. So we append ENV_CFLAGS at the end
manually, causing a bit of flag duplication.  Thanks @kacfengine for
bringing this up.
Separately include proper CPPFLAGS for every binary

Now that CORE_*FLAGS are not used anymore, I tried to explicitly include
only the needed CPPFLAGS for each binary. Unfortunately, because
cf3.defs.h is inluded almost everywhere, and it includes headers from
libutils, which needs OpenSSL includes, I had to carry the
OPENSSL_CPPFLAGS almost everywhere, and in fewer cases PCRE_CPPFLAGS as
well.

I didn't manage to completely remove those dependencies (OpenSSL, PCRE),
but at least now they are not included from within platform.h, but only
from the respective headers that need them.

To sum up, the dependency mess is less but still exists, but at least it
is visible in each makefile and we can untangle it little by little. And
every new dependency added by mistake will trigger a failure, where
previously it succeeded because CORE_CPPFLAGS included everything plus
the kitchen sink.
Remove hackishly stated dependencies, they are properly detected now.
Include stddef.h always

Fixing the broken Solaris build.
Removed unused struct, and the openssl/rsa.h dependency from cf3.defs.h.
Fix detection of getline() which has been a GNU extension before POSIX.1-2008.
Fix ./configure -C on platforms without proper printf.
Remove poinless type qualifier.

It makes zero difference to the compiler since the returned struct may
freely be assigned to a const or not struct. It also saves a bunch of
warnings when -Wextra is employed.
Merge pull request #1847 from jimis/automake_sanitisation-rebase

Automake sanitisation rebased
Simplify Makefile so that it does not create cf-upgrade-*.o objects.

The side-effect is that autoconf complains that we changed user-defined
variables. That is not true, because CFLAGS, CPPFLAGS, LDFLAGS are
defined by our configure.ac, because we blatantly ignore recommendations
at:

http://www.gnu.org/software/automake/manual/html_node/Flag-Variables-Ordering.html

The proper thing would be to empty the AM_CFLAGS etc options. But we
first need to refactor our configure.ac to not replace CFLAGS, and then
adjust the rest of Makefiles,
Ugly code has ugly bug.
Merge pull request #1848 from jimis/master

Windows cf-upgrade self-exec fix.
Remove lots of cruft from the default CPPFLAGS

This piece of code has been there since first git commit in 2008. It
refers to a similar bunch of code that modifies LDFLAGS, which has been
removed some time now. So lets remove this piece as well...
Indentation.
CF3_WITH_LIBRARY now takes into account previous *FLAGS

It is used for libxml2, which by defaults exists in a libxml2/
subdirectory inside include/. Thus, before calling the CF3_WITH_LIBRARY
macro, we set LIBXML2_CPPFLAGS according to the --with-libxml2 argument
together with the subdirectory prefix, and the macro is happily
detecting libxml2 like that.
CPPFLAGS now only include libutils directory. Yay!

So the last offenders modifying the environment CPPFLAGS were MYSQL,
POSTGRESQL, LIBXML2. They have been converted to have their own set of
blah_CPPFLAGS.

In addition, libxml2 includes were removed from within cf3.defs.h and
added to the source files that really need them.

As a result, cf-upgrade compilation line is at last free of dependencies:

gcc -DHAVE_CONFIG_H -I. -I../libutils   -std=gnu99  -pthread -g -O2 -g -Wall -Wno-pointer-sign -Werror=implicit-function-declaration -Wunused-parameter -g3 -O0  -MT cf-upgrade.o -MD -MP -MF .deps/cf-upgrade.Tpo -c -o cf-upgrade.o cf-upgrade.c