----- Original Message -----

> From: "Yiqiao Pu" <notifications@github.com>
> To: "autotest/tp-qemu" <tp-qemu@noreply.github.com>
> Sent: Thursday, March 27, 2014 3:31:36 PM
> Subject: Re: [tp-qemu] qemu.enospc: Create new VM with new params (#56)

> In qemu/tests/enospc.py:
> > @@ -127,7 +127,7 @@ def run(test, params, env):
> >
> >      error.context("Boot up guest with two disks")
> >      vm = env.get_vm(params["main_vm"])
> > -    vm.create()
> > +    vm.create(params=params)

> Actually I am thinking about if we should not use vm.create() in the tests
> scripts at all. It may cause the problems that the vm we get from env is not
> the same that we create in our test. So some very strange error may happen
> because of this in a test loop between two cases.

> As we use env to pass vm object between tests. We should pay more attention
> when we use it. So a extra function like env_process.preprocess_vm() is a
> good choice so far.

> Change the start_vm to yes when you want to start a vm is easier to accept
> than a wired error in following tests.
Yes, I prefer to env_process.preprocess_vm() too. 

> —
> Reply to this email directly or view it on GitHub .