Issue1914

issue #1914, Adding advanced indexing to theano
ok for both comment.

On Fri, Oct 17, 2014 at 4:17 PM, Pascal Lamblin <notifications@github.com>
wrote:

> In theano/tensor/var.py:
>
> > @@ -375,15 +381,17 @@ def __getitem__(self, args):
> >
> >          if advanced:
> >              if (axis is not None
> > -                and all(a == slice(None) for a in args[:axis])
> > -                and all(a == slice(None) for a in args[axis + 1:])
> > +                and all(isinstance(a, slice) and
> > +                        equal_slices(a, slice(None)) for a in args[:axis])
> > +                and all(isinstance(a, slice) and
> > +                        equal_slices(a, slice(None)) for a in args[axis + 1:])
> >                  and isinstance(args[axis], (
> >                      numpy.ndarray,
> >                      list,
> >                      TensorVariable,
>
> No, tuples mean something else, or are not valid values for advanced
> indexing in NumPy.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Theano/Theano/pull/2162/files#r19040788>.
>