I think we don't need to nitpick things too much here.
The only real solution to "strange" fixes would be: merge it, pull the
code, revert any controversial changes, re-apply the changes in a needed
way, submit a new pull request.


On Thu, Feb 6, 2014 at 3:46 PM, Yaroslav Litvinov
<notifications@github.com>wrote:

> In sysdeps/nacl/sysdep.h:
>
> > @@ -400,7 +400,7 @@
> >  INTERNAL_SYSCALL_fcntl_3 (int *err, int fd, int cmd, void *arg)
> >  {
> >      int ret=0;
> > -    if ( __zcall_fcntl(fd, cmd, arg) < 0 ){
> > +    if ( (ret=__zcall_fcntl(fd, cmd, arg)) < 0 ){
>
> see issue #5 <https://github.com/zerovm/glibc/pull/5>
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/zerovm/glibc/pull/3/files#r9500046>
> .
>