Done. Even though "self-explanatory-ness" of the names is limited anyway.
As I've mentioned before, some (two) constants defined in 
DataFormats/HcalCalibObjects are then passed to 
CalibCalorimetry/HcalPlugins, and even though they are not used across all 
HE code, they are used on two (distant) sides of HE darkening simulation 
and needs to be keept in sync.

    Salavat


On Thu, 9 Jan 2014, slava77 wrote:

> 
> In CalibCalorimetry/HcalPlugins/src/HERecalibration.h:
> 
> > @@ -13,9 +13,7 @@
> >  #include <iostream>
> >  #include "DataFormats/HcalCalibObjects/interface/HEDarkening.h"
> > 
> > -#define maxEta    14   // ieta rings for HE 
> > -#define maxLay    19   // max.number of layers 
> > -#define maxDepth  7    // with some safety margin (wrt 5)
> > +#define nDepths  7    // with some safety margin (wrt 5)
> 
> please change to something descriptive that it belongs to HE recalibration
> HERecalib_nDepth or something.
> As I mentioned in email, it's better to put this inside the class, unless it's a really general
> constant useful for all HE-related code.
> In this case, it should be defined some other place, still with enough name decorations (or a
> namespace) that clearly shows where it belongs.
> 
> —
> Reply to this email directly or view it onGitHub.[5010650__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwNDc5Mzk1OCwiZGF0YSI6eyJpZC
> I6MjMxOTE5MjR9fQ==--2ecc436f8070223e5cf40630103ce781c23a8c65.gif]
> 
> 
>