Oh, yes, that looks correct to me. Is everything done now or still WIP?


On Wed, Apr 30, 2014 at 5:28 PM, Matt Friedman <notifications@github.com>wrote:

> In notification/boardrules.php:
>
> > +	{
> > +		$username = $this->user_loader->get_username($this->get_data('from_user_id'), 'no_profile');
> > +
> > +		return $this->user->lang('BOARDRULES_NOTIFICATION', $username);
> > +	}
> > +
> > +	/**
> > +	* Get the url to this item
> > +	*
> > +	* @return string URL
> > +	*/
> > +	public function get_url()
> > +	{
> > +		$rule_id = ($this->item_id) ? '#' . $this->item_id : '';
> > +
> > +		return $this->phpbb_root_path . 'app.' . $this->php_ext . '/rules' . $rule_id;
>
> I mean, did I do it right?
> VSEphpbb@05aa6c1<https://github.com/VSEphpbb/boardrules/commit/05aa6c18fb6a9f75089aa6fb41be3713e4b8edce>
> I did not copy all the protected variable declarations.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/phpbb-extensions/boardrules/pull/93/files#r12169436>
> .
>