Sure.  Code won't be tweaked but that file will just be deleted, but yes.

Sent from mobile device.

On Apr 26, 2014, at 3:56 PM, Kent Quirk <notifications@github.com> wrote:

In lib/conversionBroker.js:

> +        armadaClient.getMembersOfGroup(viewersGroupId, token, function (error, members) {
> +          if (error != null) {
> +            return cb(error);
> +          }
> +
> +          return cb(null, members.members);
> +        });
> +      });
> +    });
> +  }
> +
> +  return {
> +    userInGroup: function(userId, groupId, cb) {
> +      async.parallel(
> +        {
> +          gatekeeper: broker.userInGroup.bind(broker, userId, groupId),

I like this design a lot; I'd like it better if you had a couple of lines
explaining that you were running both queries as a conversion model, and
that this code can probably be tweaked when we're comfortable that the
migration is complete.

--
Reply to this email directly or view it on
GitHub<https://github.com/tidepool-org/gatekeeper/pull/1/files#r12026292>
.