Disable pylint unused-argument warning.

The arguments are there to maintain the signature of some method that they
are expected to override dynamically.

Signed-off-by: mulhern <amulhern@redhat.com>
Disable unused-argument warning

In this case, the method in the parent class maintains an unused variable
because the method that overrides it in the child class requires it.

Signed-off-by: mulhern <amulhern@redhat.com>
Remove upgrading param from turnOnSwap()

It is not used in the body of turnOnSwap() or in any invocations.

Its use was removed when turnOnSwap() was changed to use ErrorHandler callbacks
in anaconda commit fa872e7e35d88008c5f9c83998d530cdd2738be8.

Signed-off-by: mulhern <amulhern@redhat.com>
Do not use *args, **kwargs idiom in various schedule* auxiliary test methods.

When the method has a single non-optional argument, the *args, **kwargs idiom
seems inappropriate.

Signed-off-by: mulhern <amulhern@redhat.com>
Do not use *args, **kwargs idiom in scheduleCreateFormat.

Do not bother to remove keyword arg usage from invocations, it makes the
invocations clearer and otherwise makes no difference.

Signed-off-by: mulhern <amulhern@redhat.com>
Make doFormat use regular style keyword parameters

doFormat is almost a leaf procedure and it is unlikely to find itself
calling procedures that require arbitrary arguments.

Signed-off-by: mulhern <amulhern@redhat.com>
Remove non-self params from FS.doResize method

The params are not used at all and this makes the signature match that of the
TmpFS.doResize method which is intended to override it.

No arguments other than self are passed where it is used in
blivet.deviceaction.

Signed-off-by: mulhern <amulhern@redhat.com>
Make formats.mount use explicit keywords instead of kwargs.

*args, *kwargs idiom is not really appropriate here.

Signed-off-by: mulhern <amulhern@redhat.com>
Make formats.teardown() not take any extra parameters.

They are not used and it is never called with any arguments.

Signed-off-by: mulhern <amulhern@redhat.com>
Omit *args from parameters in formats.setup()

All arguments are, and should be, passed as keyword arguments, it is
not a good idea to encourage calling code to use positional arguments.

Signed-off-by: mulhern <amulhern@redhat.com>
Omit *args from parameters for format.create() and formats.destroy()

All arguments are, and should be, passed as keyword arguments, it is
not a good idea to encourage calling code to use positional arguments.

Signed-off-by: mulhern <amulhern@redhat.com>
Disabled unused argument warning for kwargs in formats.destroy()

It is there because it may be necessary to pass miscellanoue arguments to
methods that formats.destroy() calls, sometime in the future.

Signed-off-by: mulhern <amulhern@redhat.com>
Omit 'args' parameter from formats constructors

It is never used and it seems like a bad idea to encourage callers to use
positional arguments.
Disable unused argument warning for 'args' in TmpFSDevice constructor

The usage is consistant with that of some, not all,
of the other Devices constructors.

Signed-off-by: mulhern <amulhern@redhat.com>
Globally disable pointless string statement warning

It warns on attribute docstring and also other multiline comments that use
double quotes and as far as I can remember has never warned about
an actual problem.

Signed-off-by: mulhern <amulhern@redhat.com>
Miscellaneous pylint fixes.

Signed-off-by: mulhern <amulhern@redhat.com>
Do not run some tests unless running on Jenkins.

Signed-off-by: mulhern <amulhern@redhat.com>