fixed: CID 718985 Big parameter passed by value

Copying large values is inefficient, consider passing by reference; size thresholds for detection can be adjusted.
In udf25::​UDFScanDir(FileAD, char *, Partition *, AD *, int): A large function call parameter or exception catch statement is passed by value (CWE-398)
fixed: CID 719001 Resource leak

The system resource will not be reclaimed and reused, reducing the future availability of the resource.
In iso9660::​ReadRecursiveDirFromSector(unsigned int, char const*): Leak of memory or pointers to system resources (CWE-404)
fixed: CID 719020 String not null terminated

The function may iterate past the end of the buffer looking for a null terminator.
In iso9660::​ReadRecursiveDirFromSector(unsigned int, char const*): A character buffer that has not been null terminated is passed to a function expecting a null terminated string (CWE-170)

Note, this also fixes an infinate loop in this parsing function.
fixed: CID 719029 Copy into fixed size buffer

The string operation will write past the end of the fixed-size destination buffer if the source buffer is too large.
In XFILE::​CRarFile::​OpenInArchive(): A source buffer of statically unknown size is copied into a fixed-size destination buffer (CWE-120)

This is semi invalid report. No overwrite would occur, but we could fail
to set passowrd since size() return allocated size not length().
fixed: CID 719030 Copy into fixed size buffer

The string operation will write past the end of the fixed-size destination buffer if the source buffer is too large.
In iso9660::​FindNextFile(CXHandle *, _WIN32_FIND_DATA *): A source buffer of statically unknown size is copied into a fixed-size destination buffer (CWE-120)
fixed: CID 719030 Copy into fixed size buffer

The string operation will write past the end of the fixed-size destination buffer if the source buffer is too large.
In iso9660::​FindNextFile(CXHandle *, _WIN32_FIND_DATA *): A source buffer of statically unknown size is copied into a fixed-size destination buffer (CWE-120)
fixed: CID 719032 Copy into fixed size buffer

The string operation will write past the end of the fixed-size destination buffer if the source buffer is too large.
In iso9660::​OpenFile(char const*): A source buffer of statically unknown size is copied into a fixed-size destination buffer (CWE-120)
fixed: CID 719150 Uninitialized scalar field

The field will contain an arbitrary value left over from earlier computations.
In XFILE::​CCurlFile::​CReadState::​CReadState(): A scalar field is not initialized by the constructor (CWE-457)
fixed: CID 719151 Uninitialized pointer field

The pointer field will point to an arbitrary memory location, any attempt to write may cause corruption.
In XFILE::​CCurlFile::​CCurlFile(): A pointer field is not initialized in the constructor (CWE-457)
fixed: CID 719152 Uninitialized pointer field

The pointer field will point to an arbitrary memory location, any attempt to write may cause corruption.
In XFILE::​CDAAPFile::​CDAAPFile(): A pointer field is not initialized in the constructor (CWE-457)
fixed: CID 719153 Uninitialized scalar field

The field will contain an arbitrary value left over from earlier computations.
In XFILE::​CFileCache::​CFileCache(XFILE::​CCacheStrategy *, bool): A scalar field is not initialized by the constructor (CWE-457)
fixed: CID 719157 Uninitialized pointer field

The pointer field will point to an arbitrary memory location, any attempt to write may cause corruption.
In XFILE::​CISOFile::​CISOFile(): A pointer field is not initialized in the constructor (CWE-457)
fixed: CID 719159 Uninitialized pointer field

The pointer field will point to an arbitrary memory location, any attempt to write may cause corruption.
In XFILE::​CMythDirectory::​CMythDirectory(): A pointer field is not initialized in the constructor (CWE-457)
fixed: CID 719160 Uninitialized pointer field

The pointer field will point to an arbitrary memory location, any attempt to write may cause corruption.
In XFILE::​CMythSession::​CMythSession(CURL const&): A pointer field is not initialized in the constructor (CWE-457)
fixed: CID 719162 Uninitialized scalar field

The field will contain an arbitrary value left over from earlier computations.
In XFILE::​CPluginDirectory::​CPluginDirectory(): A scalar field is not initialized by the constructor (CWE-457)
fixed: CID 719163 Uninitialized scalar field

The field will contain an arbitrary value left over from earlier computations.
In XFILE::​CRTVFile::​CRTVFile(): A scalar field is not initialized by the constructor (CWE-457)
fixed: CID 719164 Uninitialized scalar field

The field will contain an arbitrary value left over from earlier computations.
In XFILE::​CRarFileExtractThread::​CRarFileExtractThread(): A scalar field is not initialized by the constructor (CWE-457)
fixed: CID 719165 Uninitialized scalar field

The field will contain an arbitrary value left over from earlier computations.
In XFILE::​CRarFile::​CRarFile(): A scalar field is not initialized by the constructor (CWE-457)
fixed: CID 719166 Uninitialized scalar field

The field will contain an arbitrary value left over from earlier computations.
In CFileInfo::​CFileInfo(): A scalar field is not initialized by the constructor (CWE-457)
fixed: CID 719167 Uninitialized scalar field

The field will contain an arbitrary value left over from earlier computations.
In XFILE::​CSAPFile::​CSAPFile(): A scalar field is not initialized by the constructor (CWE-457)