On Mon, May 19, 2014 at 5:28 PM, Robert David Grant <
notifications@github.com> wrote:

> In distarray/dist/maps.py:
>
> > @@ -592,3 +592,12 @@ def get_dim_data_per_rank(self):
> >          coord_and_dd = [zip(*cdd) for cdd in cart_dds]
> >          rank_and_dd = sorted((self.rank_from_coords[c], dd) for (c, dd) in coord_and_dd)
> >          return [dd for (_, dd) in rank_and_dd]
> > +
> > +    @property
> > +    def PRECISE_INDEXING(self):
>
> On Mon, May 19, 2014 at 5:18 PM, Kurt Smith <notifications@github.com>wrote:
> Why all caps? I never took you for a FORTRAN 77 aficionado, @bgrant<https://github.com/bgrant>
> <https://github.com/bgrant> .
> What? You didn't seem my Project Euler solutions in FORTRAN 77?
> https://github.com/bgrant/project-euler/blob/master/fortran/euler.f
>

Nice!  You should capitalize EVERYTHING, though.  And what's with
explicitly declaring your function variables?  Real programmers use
implicit typing.


>  But seriously, you're probably right. It seemed kind of like a constant
> or a flag to me, but I suppose the fact that it's a function belies that.
> Maybe I could rename it to `allows_precise_indexing` or
> `has_precise_indexing`?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/enthought/distarray/pull/377/files#r12819899>
> .
>



-- 
Kurt W. Smith, Ph.D. <ksmith@enthought.com>
Enthought, Inc. <http://www.enthought.com>  | 512.536.1057