My comment is based on my having seen a 500 in the log.
Sent using OWA for iPhone
________________________________
From: Phil McGachey <notifications@github.com>
Sent: Tuesday, May 27, 2014 9:34:42 AM
To: Harvard-University-iCommons/icommons_lti_tools
Cc: Snowden, Carter
Subject: Re: [icommons_lti_tools] Feature/add people tool (#28)


In add_people/views.py:

>
> +
>      sections = get_list_sections(canvas_course_instance_id)


I don't follow how calling this method on a course with no sections returns 500 (although I could be reading the code wrong). It looks to me like if you call the method with a course_instance_id parameter that refers to a course that doesn't exist you will get a 500 (although it might make sense for that to be a 404 or a 403, depending on our security model). If you call it with a valid canvas_course_instance_id you should render the create_section_form page with an empty sections list (ignoring for now the server failure issue that you raised above). Am I missing something?

-
Reply to this email directly or view it on GitHub<https://github.com/Harvard-University-iCommons/icommons_lti_tools/pull/28/files#r13077273>.