It is because of add_hist being false, the test is to make sure we don't
pop "hello" when we're trying to get rid of the blank line (which would
have never been added to the history)
On Feb 15, 2014 11:16 AM, "George Brocklehurst" <notifications@github.com>
wrote:

> In spec/units/readline_blank_filter_spec.rb:
>
> > +    it 'does not enter lines consisting of only whitespace into the history' do
> > +      readline_blank_filter = ReadlineBlankFilter.new(fake_readline)
> > +
> > +      fake_readline.type("\n   \n")
> > +      readline_blank_filter.readline('>', true)
> > +
> > +      expect(readline_blank_filter::HISTORY.to_a).to be_empty
> > +    end
> > +
> > +    it 'does not modify the history if add_hist is false' do
> > +      readline_blank_filter = ReadlineBlankFilter.new(fake_readline)
> > +
> > +      fake_readline.type('hello')
> > +      readline_blank_filter.readline('>', true)
> > +      fake_readline.type(' ')
> > +      readline_blank_filter.readline('>', false)
>
> This line being added here only contains whitespace, so it's not clear if
> the test passes because add_hist is false (which is what the example
> description says we're testing here), or because of the whitespace filter
> (as covered in the previous example)
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/thoughtbot/gitsh/pull/77/files#r9773697>
> .
>