Just to check. Is this just a style thing? Or does it help with the current bugs with oF full screen on windows?


-- 
Typed by touchscreen

Elliot Woods
elliot@KimchiAndChips.com

UK : +447944977628
KR : +821034458086



> On 10 Apr 2014, at 17:19, Christoph Buchner <notifications@github.com> wrote:
> 
> In libs/openFrameworks/app/ofAppGLFWWindow.cpp:
> 
> > @@ -740,23 +740,30 @@ void ofAppGLFWWindow::setFullscreen(bool fullscreen){
> >   
> >          if( bMultiWindowFullscreen ){
> >   
> > -            float totalWidth = 0.0;
> > -            float maxHeight  = 0.0;
> > +            int minX = 0;
> > +            int maxX = 0;
> > +            int minY = 0;
> > +	    int maxY = 0;
> Our published OF code style to the rescue ;-)
> 
> Use tabs for indentation and set your tab width to 4 spaces. Keep in mind the Github source code viewer uses a tab width of 8 spaces.
> 
> The latter is why these errors are visible in the PR view, when people are mixing tabs and spaces in a file.
> 
> \
> Reply to this email directly or view it on GitHub.