Thank you, I will look at that, and test


On Thu, Mar 20, 2014 at 12:27 PM, Oliver Gond¾a <notifications@github.com>wrote:

> In core/src/main/java/hudson/model/AbstractProject.java:
>
> >      }
> >
> >      private WorkspaceOfflineReason workspaceOffline(R build) throws IOException, InterruptedException {
> >          FilePath ws = build.getWorkspace();
> > +        Label label = getAssignedLabel();
> > +
> > +        if (isAllSuitableNodesOffline(build)) {
> > +            // if (label.getClouds() != null) {
>
> Why not use label.getClouds().isEmpty() to decide what case to return? It
> seems to duplicate what Label.getClouds() does. There is definitely no
> reason to keep this code commented out.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/jenkinsci/jenkins/pull/1092/files#r10790793>
> .
>



-- 
Best regards / Med venlig hilsen

Jens Brejner

email: jbrejner@praqma.net  /  www.praqma.com
phone +45 22 616 313
skype: jbrejner