Per Spec, allow Authorization Server to -maybe- issue a new Refresh Token.

 The authorization server MAY issue a new refresh token, in which case
   the client MUST discard the old refresh token and replace it with the
   new refresh token.  The authorization server MAY revoke the old
   refresh token after issuing a new refresh token to the client.  If a
   new refresh token is issued, the refresh token scope MUST be
   identical to that of the refresh token included by the client in the
   request.

This commit allows users to specifiy the time before the Refresh Token
expire time to issue a new Refresh Token.
“Should" seems like this might actually have an affect, more that being a question.” Is" or “Has" is what I see most commonly used for these boolean get methods. 

I can just see people confusing these with setters. 

-- 
Phil

From: Alex Bilbie <notifications@github.com>
Reply: thephpleague/oauth2-server <reply@reply.github.com>>
Date: December 21, 2014 at 5:00:41 PM
To: thephpleague/oauth2-server <oauth2-server@noreply.github.com>>
Cc: Phil Sturgeon <me@philsturgeon.uk>>
Subject:  Re: [oauth2-server] Per Spec, allow Authorization Server to -maybe- issue a new Refresh Token. (#286)  

In src/Grant/RefreshTokenGrant.php:

> @@ -58,6 +65,26 @@ public function getRefreshTokenTTL()
>      }
>   
>      /**
> +     * Set the rotation boolean of the refresh token
> +     *
> +     * @return int
> +     */
> +    public function setRefreshTokenRotate($refreshTokenRotate)
> +    {
> +        $this->refreshTokenRotate = $refreshTokenRotate;
> +    }
> +
> +    /**
> +     * Get rotation boolean of the refresh token
> +     *
> +     * @return int
> +     */
> +    public function getRefreshTokenRotate()
And this method should be called shouldRefreshTokensRotate

—
Reply to this email directly or view it on GitHub.