FredPluginFCPMessageHandler: Use the new container class FCPPluginMessage to encapsulate the parameters passed to message handling functions; Update JavaDoc
- The fact that we now make message handlers return the reply message instead of sending them on their own using the send() functions of the FCPPluginClient at first seems like a unnecessary restriction. However it is not: It allows us to unify the format of success/failure messages. They will always be indicated by the Boolean success in the FCPPluginMessage, so their on-network format can always look the same. Previously, stuff like WOT had many different values in the SimpleFieldSet such as "IdentityCreated", "TrustSet" etc for indicating the success of an operation. Now success/failure messages will all look the same. This in turn allows the synchronous send functions to monitor the network data for those messages to allow the synchronous and thereby blocking operation to return. Notably, the on-network format can stay as is :)
- In addition to using the new FCPPluginMessage, the JavaDoc of various stuff in FredPluginFCPMessageHandler is also clarified.
- I used the Eclipse feature for changing function signatures, so other classes which reference this are also changed. The indentation / line length will be fixed in the following commit.