Babel and Query Reports

I needed a way to have a common print format for two reports. Hence I specified a common file for both reports. 

Sent from my phone

> On 19-Jul-2014, at 21:29, Rushabh Mehta <notifications@github.com> wrote:
> 
> In frappe/widgets/query_report.py:
> 
> > @@ -56,6 +54,27 @@ def get_script(report_name):
> >  		"html_format": html_format
> >  	}
> >  
> > +def get_html_format(print_path, report, module):
> > +	html_format = None
> > +	if os.path.exists(print_path):
> > +		with open(print_path, "r") as f:
> > +			html_format = f.read()
> > +
> > +	elif report.is_standard == "Yes" and report.report_type == "Script Report":
> > +		try:
> > +			# check for html format file path in report's python file
> > +			report_py = frappe.get_module(get_report_module_dotted_path(module, report.name))
> > +			if hasattr(report_py, "print_path"):
> why not implicit as we have used in the query report. its best to keep both explicit or both implicit
> 
> —
> Reply to this email directly or view it on GitHub.