ASSERT in ScreenOrientationController::{un,}lock() if no m_client.

BUG=162827

Review URL: https://codereview.chromium.org/407923002

git-svn-id: svn://svn.chromium.org/blink/trunk@178771 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Fix a crash in V8AbstractEventListener::handleEvent

handleEvent() should check scriptState->contextIsEmpty() before doing anything that uses scriptState. This CL also adds a check for scriptState->executionContext() just in case (I'm not sure if it's really needed).

BUG=396104
TEST=I cannot reproduce the crash.

Review URL: https://codereview.chromium.org/411463006

git-svn-id: svn://svn.chromium.org/blink/trunk@178772 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Add a UseCounter for HTMLPreElement.width

The content attribute has no effect, so this API is completely useless.
It is widely implemented, but was removed from spec, so attempting
removal seems worthwhile, as it could leave HTMLPreElement empty.

http://whatwg.org/html#the-pre-element

Review URL: https://codereview.chromium.org/415533002

git-svn-id: svn://svn.chromium.org/blink/trunk@178773 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Remove isSVGPath

This method is not needed since casting to RenderSVGShape is good enough, in SVGPathElement we only call methods on that class, nothing RenderSVGPath specific.

Review URL: https://codereview.chromium.org/411743002

git-svn-id: svn://svn.chromium.org/blink/trunk@178774 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Rebase global-constructors-listing following r178747

Let's get the safety net back in place ASAP. Patches that modify
the set of global constructors should include updated expectations
for this test to indicate that the changes are intentional.

BUG=388780
TBR=jinho.bang@samsung.com
NOTRY=true

Review URL: https://codereview.chromium.org/409073004

git-svn-id: svn://svn.chromium.org/blink/trunk@178775 bbb929c8-8fbe-4397-9dbb-9b2b20218538
bindings: Makes DOM classes inherit from ScriptWrappable.

This CL makes most of DOM classes inherit from ScriptWrappable, except for classes in core/css/ directory and subclasses of SVGAnimatedPropertyBase.

This CL may increase the size of these classes by +16 or +8 bytes.  +8 bytes for |m_wrapperOrTypeInfo| (type of uintptr_t) in ScriptWrappable.  Another +8 bytes for vtbl.

BUG=235436

Review URL: https://codereview.chromium.org/407073009

git-svn-id: svn://svn.chromium.org/blink/trunk@178776 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Use the mediaControlsButton() helper more in media tests

Review URL: https://codereview.chromium.org/411833006

git-svn-id: svn://svn.chromium.org/blink/trunk@178777 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Oilpan: fix WebSockets unit tests after r178758.

Explicitly disconnect the channel on test completion, putting the heap
object in the expected state by the time the next GC sweep happens.

TBR=oilpan-reviews@chromium.org,tyoshino@chromium.org,yhirano@chromium.org,hiroshige@chromium.org
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/410263002

git-svn-id: svn://svn.chromium.org/blink/trunk@178778 bbb929c8-8fbe-4397-9dbb-9b2b20218538
LocalWindow::printErrorMessage(): check if frame is available.

If there's no frame, there's no console to add message to either.

R=haraken@chromium.org
BUG=376704

Review URL: https://codereview.chromium.org/413683002

git-svn-id: svn://svn.chromium.org/blink/trunk@178779 bbb929c8-8fbe-4397-9dbb-9b2b20218538
When overwriting a persistent handle, actually overwrite it

BUG=390928
R=haraken@chromium.org

Review URL: https://codereview.chromium.org/412843003

git-svn-id: svn://svn.chromium.org/blink/trunk@178780 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Update TestExpectations.

BUG=392764,396791,396798
TEST=none
TBR=haraken

Review URL: https://codereview.chromium.org/412993003

git-svn-id: svn://svn.chromium.org/blink/trunk@178781 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Reland: 'Fix Performance::now() for browser navigations'.

Previously this was reverted because it was introducing an assert that
doesn't hold in some valid cases. This time we're skipping this assert.

Original review: https://codereview.chromium.org/379873002/
More details:
https://code.google.com/p/chromium/issues/detail?id=395817#c10

Original commit message:

Performance::now() is defined as number of milliseconds since
navigationStart. It works correctly for renderer-initiated navigations,
but for browser-initiated ones we override the navigationStart with the
recording taken on the browser side and this is not represented in
Performace::now().

Among other reasons to be sad about this, this bug makes Chromium's
pagecyclers not represent the renderer initialization times in the
records.

This patch fixes this by adjusting the fields that are supposed to
correspond to navigationStart when we change navigationStart from the
embedder.

BUG=376004

Review URL: https://codereview.chromium.org/417513002

git-svn-id: svn://svn.chromium.org/blink/trunk@178782 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Re-enabling all stale expectations temporarily to see which tests are still failing.

The layout test bots are pretty green, so I'm going to try this.  I expect a
significant amount of fallout.

BUG=none
TEST=none
TBR=haraken

Review URL: https://codereview.chromium.org/418583005

git-svn-id: svn://svn.chromium.org/blink/trunk@178784 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Test expectation updates for recent bot outputs.

BUG=30536,250520,307781,314947,352801,357438,360889,374936,374961,395676
TEST=none
TBR=haraken

Review URL: https://codereview.chromium.org/417803002

git-svn-id: svn://svn.chromium.org/blink/trunk@178785 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Mark windows form control tests as NeedsManualRebaseline for skia roll

Once we roll skia to f73c237291bb1fc698f688d8a9b1cdd23838ed18 a bunch
of windows form tests needs to be rebaselines.

BUG=395043
R=bungeman@chromium.org

Review URL: https://codereview.chromium.org/414873003

git-svn-id: svn://svn.chromium.org/blink/trunk@178787 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Improve GN build test targets.

Add missing dependency on make_core_generated_private_script_for_testing.

Rename wtf:unittest_helpers to wtf:test_support for project consistency (I'm trying to standardize everything on "test_support").

Add blink:test_support target.

BUG=

Review URL: https://codereview.chromium.org/410083007

git-svn-id: svn://svn.chromium.org/blink/trunk@178788 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Peer::m_syncHelper should be cleared when the Peer is destroyed

This is a speculative fix for crashes in websocket tests in oilpan bots.

Peer::m_syncHelper should be cleared when the Peer object is destroyed. Otherwise, the main thread keeps retaining a Member to the on-heap SyncHelper object allocated in the worker thread's heap even after the worker thread shuts down. This is not allowed in oilpan. All references to on-heap objects on worker thread's heap should be cleared before the worker thread shuts down.

BUG=396503

Review URL: https://codereview.chromium.org/411543008

git-svn-id: svn://svn.chromium.org/blink/trunk@178789 bbb929c8-8fbe-4397-9dbb-9b2b20218538
A pointer should be sufficient for Range::compareBoundaryPoints

It is because this function does not save Range object to anywhere.

Review URL: https://codereview.chromium.org/409283003

git-svn-id: svn://svn.chromium.org/blink/trunk@178790 bbb929c8-8fbe-4397-9dbb-9b2b20218538
[refactor] Remove the redundant blink:: prefix from modules/crypto.

Review URL: https://codereview.chromium.org/416593002

git-svn-id: svn://svn.chromium.org/blink/trunk@178791 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Remove CSSTransformsUnprefixed runtime flag (status=stable)

We're now shipping css transforms unprefixed and there's no reason to
keep the RuntimeEnabledFeatures flag around.

BUG=154772

Review URL: https://codereview.chromium.org/409103002

git-svn-id: svn://svn.chromium.org/blink/trunk@178794 bbb929c8-8fbe-4397-9dbb-9b2b20218538