probably... will do


On Thu, Apr 24, 2014 at 4:36 PM, teravest <notifications@github.com> wrote:

> In biom/commands/table_validator.py:
>
> >
> >      def run(self, **kwargs):
> > -        table_json = kwargs['table_json']
> > +        is_json = kwargs['is_json']
> > +
> > +        # this is not pyqi-appriopriate, but how we parse this thing is
> > +        # dependent on runtime options :(
> > +        with biom_open(kwargs['table']) as f:
> > +            if is_json:
> > +                kwargs['table'] = json.load(f)
> > +                return self._validate_json(**kwargs)
> > +            elif HAVE_H5PY:
> > +                kwargs['table'] = f
> > +                return self._validate_hdf5(**kwargs)
> > +            elif not HAVE_H5PY:
>
> can't you have else:
> instead of elif not HAVE_H5PY:
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/biocore/biom-format/pull/308/files#r11976173>
> .
>