On Fri, Feb 7, 2014 at 1:07 PM, Keith Rarick <notifications@github.com>wrote:

> In hkclient/client.go:
>
> > +	"github.com/bgentry/heroku-go"
> > +	"github.com/heroku/hk/postgresql"
> > +	"net/http"
> > +	"net/url"
> > +	"os"
> > +	"strings"
> > +)
> > +
> > +type Clients struct {
> > +	ApiURL string
> > +	Client *heroku.Client
> > +
> > +	PgClient *postgresql.Client
> > +}
> > +
> > +func HkClients(nrc *HkNetRc, agent string) (*Clients, error) {
>
> This name is a little weird, and has stutter for users:
> hkclient.HkClients(...).
> Consider New or Open or something if you can find an appropriate one.
> An plain verb like would be good if Clients is the primary type of this
> package,
> which it seems to be.
>
> Same goes for HkNetRc and any other prefixed exported symbols.
> I'd suggest Netrc (or NetRc if you prefer that capitalization) instead.
>
That's a good idea.