(maint) Always pass an arg to shared behavior block
(maint) Require rspec/mocks over deprecated spec/mocks
(maint) Never require rspec/mocks

We use mocha for stubbing and mocking; requiring the rspec mocks as well
will break things in RSpec 2.14.
(maint) Avoid rspec examples using variable behavior

Given an object with an attr_accessor and using an example shortcut like so:

    subject { metadata.to_hash }

    its(:keys) do
      subject.sort.should == %w[ name version author summary license source issues_url project_page dependencies ].sort
    end

The value of subject in the example varies between RSpec 2.11 and 2.13.
This commit removes the shortcut in favor of a slightly longer but more
compatible test that explicitly invokes the #keys method and does an
expectation on that.
(maint) Remove deprecated `.to_not raise_error(args)` calls

From RSpec:

    DEPRECATION: `expect { }.not_to raise_error(SpecificErrorClass, message)` is deprecated. Use `expect { }.not_to raise_error` (with no args) instead.

This commit removes all args from `.to_not raise_error` expectations.
(maint) Remove nonfunctional directoryservice test

It's not possible to test
Puppet::Provider::NameService::DirectoryService without stubbing out a
huge amount of code, which is done by a different test. The removed test
behaved almost identically like the following test so we can remove this
without losing test coverage.
(maint) Replace invocations of `subject` and `let` in `before(:all)`
(maint) Update rspec version to 2.14
Merge pull request #2874 from adrienthebo/maint/master/update-rspec

Maint/master/update rspec
(PUP-2918) Remove reduntant acceptance test for new build output

Before this commit, the acceptance tests fail because the output of the
puppet module build action has changed for missing Modulefile and
metadata.json files. With this commit, the acceptance test is removed,
because this behavior is covered in the spec tests.
Merge pull request #2888 from andersonmills/bug/master/pup2918-acceptance_tests_for_build_messages

(PUP-2918) Remove redundant acceptance test for new build output
Merge branch 'master' into puppet-4