CE/splits

I previously had that as 'updateSplitsWithOdometerReading' which is more
descriptive but i didn't like it because we aren't passing in the odometer
reading as we don't have to.  I don't love it but i prefer initing the
object with the Odometer over passing in the reading.

On Mon, Dec 1, 2014 at 3:22 PM, Fabian <notifications@github.com> wrote:

> In RandomRun/Navigation/SplitCalculator.m:
>
> > +{
> > +    self = [super init];
> > +    if (self == nil) {
> > +        return nil;
> > +    }
> > +    _odometer = odometer;
> > +    _splitDistance = (splitUnit == MileSplits) ? mPerMile : mPerkm;
> > +    _split_t1 = self.odometer.reading.timestamp;
> > +    _split_d1 = self.odometer.reading.completedDistance;
> > +    _currentSplit = 0;
> > +    _previousSplit = 0;
> > +    return self;
> > +}
> > +
> > +- (void)updateSplits
> > +{
>
> An updateX method with no parameter just seems kind of weird in this
> case. It's better than doThing in that it loosely tells us that it has a
> side-effect on our split-related properties. But otherwise it could be
> doing anything.
>
> If there's a clear next task though, you may as well leave this as-is and
> move on.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mojotech/random-run/pull/54/files#r21116551>.
>