yeah, I really don't like this syntax, intercept and should produce were so
much more explicit I think. Will switch to an[Exception].

I am working into getting sbt-release in sumac to simplify the release
process.

P

On Thu, Apr 24, 2014 at 1:54 PM, imranr <notifications@github.com> wrote:

> In core/src/test/scala/com/quantifind/sumac/FieldArgsTest.scala:
>
> > @@ -131,7 +131,7 @@ class FieldArgsTest extends FunSuite with ShouldMatchers {
> >      System.identityHashCode(s.select) should be (id)
> >      s.select.options should be (Set("a", "b", "c"))
> >
> > -    evaluating {s.parse(Array("--select", "q"))} should produce [ArgException]
> > +    the[ArgException] thrownBy  {s.parse(Array("--select", "q"))}
>
> this is a really tiny nit ... but I find this syntax doesn't make it clear
> that its checking an exception should be thrown. In the cases where the
> exception isn't being returned for more checks, like this one, can you
> switch to the other syntax you use elsewhere: an[ArgException] should be
> thrownBy {...}
> ?
>
> otherwise, this looks fine to me. If you don't feel like fixing this now,
> that is fine, you can just merge it.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/quantifind/Sumac/pull/44/files#r11958745>
> .
>