Inline agg

This is part 1: Serial Inline aggregation contain table agg and group by agg with index.

Waiting for Jenkins.

I agree that this change makes nothing worse. I will log 2 tickets -- one
missed optimization, one potential wrong answer.

*Paul Martel,* Software Engineer
*VoltDB, Inc.*
*E:* pmartel@voltdb.com
www.voltdb.com <http://voltdb.com>
Follow VoltDB on Twitter <https://twitter.com/voltdb>, Facebook
<https://www.facebook.com/VoltDB?sk=wall>, and LinkedIn
<http://www.linkedin.com/company/voltdb>


On Thu, Jun 12, 2014 at 10:11 PM, Xin Jia <notifications@github.com> wrote:

> In src/frontend/org/voltdb/planner/ParsedSelectStmt.java:
>
> > +        int offsetParamIndex = parameterCountIndexById(m_offsetParameterId);;
> > +
> > +        // The coordinator's top limit graph fragment for a MP plan.
> > +        // If planning "order by ... limit", getNextSelectPlan()
> > +        // will have already added an order by to the coordinator frag.
> > +        // This is the only limit node in a SP plan
> > +        m_limitNodeTop = new LimitPlanNode();
> > +        m_limitNodeTop.setLimit((int) m_limit);
> > +        m_limitNodeTop.setOffset((int) m_offset);
> > +        m_limitNodeTop.setLimitParameterIndex(limitParamIndex);
> > +        m_limitNodeTop.setOffsetParameterIndex(offsetParamIndex);
> > +
> > +        // check if limit can be pushed down
> > +        m_limitCanPushdown = !m_distinct;
> > +        if (m_limitCanPushdown) {
> > +            for (ParsedColInfo col : m_displayColumns) {
>
> This piece of code was copied from PlanAssember that was executing per
> access plan without any reason that needs to. So I moved them into query
> parse part and reuse the information when needed.
>
> I do not understand your concern here and we may need to talk about the
> problem in person. Anyway, Would you create a new separate ticket to
> improve or fix LIMIT expression and move on LIMIT related from that? As
> this change set does not make it worse, but not as better as you think if I
> understand correctly.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/VoltDB/voltdb/pull/1415/files#r13736279>.
>