Rename api ErrorList for clarity

The factoring could use some attention, to be sure.

On Fri, Oct 24, 2014 at 10:39 AM, Daniel Smith <notifications@github.com>
wrote:

> In pkg/api/errors/validation.go:
>
> > @@ -113,20 +113,22 @@ func NewFieldNotFound(field string, value interface{}) ValidationError {
> >  	return ValidationError{ValidationErrorTypeNotFound, field, value}
> >  }
> >
> > -// ErrorList is a collection of errors.  This does not implement the error
> > -// interface to avoid confusion where an empty ErrorList would still be an
> > -// error (non-nil).  To produce a single error instance from an ErrorList, use
> > -// the ToError() method, which will return nil for an empty ErrorList.
> > -type ErrorList util.ErrorList
> > -
> > -// ToError converts an ErrorList into a "normal" error, or nil if the list is empty.
> > -func (list ErrorList) ToError() error {
> > +// ValidationErrorList is a collection of ValidationErrors.  This does not
> > +// implement the error interface to avoid confusion where an empty
> > +// ValidationErrorList would still be an error (non-nil).  To produce a single
> > +// error instance from a ValidationErrorList, use the ToError() method, which
> > +// will return nil for an empty ValidationErrorList.
> > +type ValidationErrorList util.ErrorList
>
> Oh, I see, it's not in the validation package. This makes me question our
> factoring. It's very weird that the validation package has to use a
> ValidationErrorList from the error package. Not worth fixing at the moment.
>
> --
> Reply to this email directly or view it on GitHub
> <https://github.com/GoogleCloudPlatform/kubernetes/pull/1986/files#r19352691>
> .
>