Added variant on_sale? tests