Okey doke, I'll defer to @reaperhulk then.


On Sat, Mar 29, 2014 at 6:51 PM, Mohammed Attia <notifications@github.com>wrote:

> In tests/hazmat/primitives/test_dsa.py:
>
> > +        'e657d41766a99991ac8787694f4185d6f91d7627048f827b405ec67bf2fe56141c4c5'
> > +        '81d8c317333624e073e5879a82437cb0c7b435c0ce434e15965db1315d64895991e6b'
> > +        'be7dac040c42052408bbc53423fd31098248a58f8a67da3a39895cd0cc927515d044c'
> > +        '1e3cb6a3259c3d0da354cce89ea3552c59609db10ee989986527436af21d9485ddf25'
> > +        'f90f7dff6d2bae'
> > +    }
> > +
> > +    def test_invalid_parameters_argument_types(self):
> > +        with pytest.raises(TypeError):
> > +            dsa.DSAParameters(None, None, None)
> > +
> > +    def test_load_dsa_example_keys(self):
> > +        parameters = dsa.DSAParameters(
> > +            modulus=int(self._parameters_1024['p']),
> > +            subgroup_order=int(self._parameters_1024['q']),
> > +            generator=int(self._parameters_1024['g']))
>
> They're missing indeed, will fix. I moved them to the dicts before but
> @reaperhulk <https://github.com/reaperhulk> said we should keep them like
> this for consistency with RSA.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/pyca/cryptography/pull/868/files#r11096331>
> .
>



-- 
"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: 125F 5C67 DFE9 4084