fix a segfault

scope_active_.size() = SCOPE_COUNT, so scope_active_[SCOPE_COUNT] is
undefined behaviour.

it seems like in add_hotkey it can happen that
hotkey::get_hotkey_command(item.get_command()).scope return SCOPE_COUNT
for wml hotkeys
Fixed Gold arguments.
gui2/tslider: Add minimal variant without a text label

The default variant's text label is both inflexible in content (can't
customize the format for non-edge values) and layout (reserves way more
space than it needs at a time for its text label, often resulting in
huge horizontal gaps between a slider and an adjacent widget). This
makes it unsuitable for use in gui2::tchat_log.

This new minimal variant will be wired into gui2::tchat_log next.
gui2/tchat_log: Use a separate proper label for the page number text

This replaces the page number slider with a "minimal" variant slider and
an adjacent label widget whose text we enter manually.

The label format is "<PAGE>/<COUNT>" and it's untranslatable. Hopefully
this shouldn't cause any localization issues since it's all numbers and
we currently can't use alternative numeral systems anyway.

I'm leaving the page slider's maximum_value_label attribute intact just
in case this needs to be reverted later, since it's going into the 1.12
branch too.
validator: Conform to the new parser and preprocessor output style

Because I overlooked the validator's dependency on the preprocessor
lineno_string() function, we wound up with badly-formatted output like
the following:

> 20140619 03:16:32 error validation:
> gui/default/widget/slider_minimal.cfg:53
>     included from gui/default.cfg:30
>     included from gui/default/widget/slider_minimal.cfg:100
>     included from gui/default.cfg:30: tag [wrong_tag] may not be used in [resolution]

This commit changes the validator's error formatting functions to
produce output more akin to the parser/preprocessor under the new
scheme introduced in version 1.11.10:

> 20140619 03:17:36 error validation: Tag [wrong_tag] may not be used in [resolution]
> at gui/default/widget/slider_minimal.cfg:53
>     included from gui/default.cfg:30
>     included from gui/default/widget/slider_minimal.cfg:100
>     included from gui/default.cfg:30

There are no translatable strings involved in this change, so this
commit may be safely backported to 1.12.
validator: Remove redundant "on line N" output fragments

They were redundant even before my changes.
validator: Make missing attribute error format more consistent with the rest

Instead of:
> In tag slider_definition which begins here,  missing key id

Use:
> Missing key 'id=' in tag [slider_definition]

Since otherwise the wording is very awkward with the new format (the
file:line line comes after the error), all other key-related messages
use "'key='" to denote attribute names, and there's a double-blank typo
that was there even before I first touched this code.
validator: Update changelog for previous three commits
remove unnecessary include

This include is apparently totally unnecessary and we compile fine
without it.
Merge branch 'master' of git://github.com/wesnoth/wesnoth
fixup an include

This unordered_map thing was totally unnecessary and this header
is included everywhere. From the logs it looks like the boost
unordered_map is a fairly expensive include.
fixup includes, remove include SDL.h from src/events.hpp
fixup unnecessary include
fixup includes
fixup includes
fixup includes in clipboard
fixup includes, use uint8_t in key.hpp instead of Uint8
fixup 871f2f4591cf

Use the boost cstdint include like we do in the rest of the
project
fixup includes (put inside the include guard)
NR S1 Dialogue/Map Update

The dialogue was changed to make it less basic, and the map was altered
to have the player start in the West, with Al'Tar now to the North.
This enables the player to be more actively involved in the battle
earlier on in the scenario.